fix(iOS): bug ios simulator infinite loop rotating orientation #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR fixes #73 where only on iOS 15, we fall into a loop once we listen for device orientation changes and we lock the interface to the same device orientation.
Specifically, this happens because we use
UIDevice.current.setValue
to update the orientation when we rotate the device, doing this it triggers theorientationDidChangeNotification
event listener that sends a newdeviceOrientationDidChange
event and the loop starts.So we simply track the
locking
status and avoid sending the deviceOrientationDidChange when we are currently locking the interface to a specific orientation