Fix data race, close #7287 #7110 #7539 #7108

Author: jinzhu

schema/relationship.go

@@ -75,9 +75,7 @@ func (schema *Schema) parseRelation(field *Field) *Relationship {
 		}
 	)
 
-	cacheStore := schema.cacheStore
-
-	if relation.FieldSchema, err = getOrParse(fieldValue, cacheStore, schema.namer); err != nil {
+	if relation.FieldSchema, err = getOrParse(fieldValue, schema.cacheStore, schema.namer); err != nil {
 		schema.err = fmt.Errorf("failed to parse field: %s, error: %w", field.Name, err)
 		return nil
 	}
@@ -147,6 +145,9 @@ func hasPolymorphicRelation(tagSettings map[string]string) bool {
 }
 
 func (schema *Schema) setRelation(relation *Relationship) {
+	schema.Relationships.Mux.Lock()
+	defer schema.Relationships.Mux.Unlock()
+
 	// set non-embedded relation
 	if rel := schema.Relationships.Relations[relation.Name]; rel != nil {
 		if len(rel.Field.BindNames) > 1 {
@@ -590,13 +591,21 @@ func (schema *Schema) guessRelation(relation *Relationship, field *Field, cgl gu
 	// build references
 	for idx, foreignField := range foreignFields {
 		// use same data type for foreign keys
+		schema.Relationships.Mux.Lock()
+		if schema != foreignField.Schema {
+			foreignField.Schema.Relationships.Mux.Lock()
+		}
 		if copyableDataType(primaryFields[idx].DataType) {
 			foreignField.DataType = primaryFields[idx].DataType
 		}
 		foreignField.GORMDataType = primaryFields[idx].GORMDataType
 		if foreignField.Size == 0 {
 			foreignField.Size = primaryFields[idx].Size
 		}
+		schema.Relationships.Mux.Unlock()
+		if schema != foreignField.Schema {
+			foreignField.Schema.Relationships.Mux.Unlock()
+		}
 
 		relation.References = append(relation.References, &Reference{
 			PrimaryKey:    primaryFields[idx],

schema/relationship_test.go

@@ -3,9 +3,11 @@ package schema_test
 import (
 	"sync"
 	"testing"
+	"time"
 
 	"gorm.io/gorm"
 	"gorm.io/gorm/schema"
+	"gorm.io/gorm/utils/tests"
 )
 
 func checkStructRelation(t *testing.T, data interface{}, relations ...Relation) {
@@ -996,3 +998,46 @@ func TestParseConstraintNameWithSchemaQualifiedLongTableName(t *testing.T) {
 		)
 	}
 }
+
+type InfoRelation struct {
+	ID    int
+	Code  string
+	Info1 []*Info1 `gorm:"foreignkey:Code;references:Code"`
+	Info2 []*Info2 `gorm:"foreignkey:Code;references:Code"`
+}
+
+type Info1 struct {
+	CreatedAt time.Time
+	UpdatedAt time.Time
+	Code      string
+	Relation  []*InfoRelation `gorm:"foreignkey:Code;references:Code"`
+}
+
+type Info2 struct {
+	CreatedAt time.Time
+	UpdatedAt time.Time
+	Code      string
+	Relation  []*InfoRelation `gorm:"foreignkey:Code;references:Code"`
+}
+
+func TestDataRace(t *testing.T) {
+	syncMap := &sync.Map{}
+	for i := 0; i < 10; i++ {
+		go func() {
+			schema.Parse(&Info1{}, syncMap, schema.NamingStrategy{IdentifierMaxLength: 64})
+		}()
+
+		go func() {
+			schema.Parse(&Info2{}, syncMap, schema.NamingStrategy{IdentifierMaxLength: 64})
+		}()
+
+		go func() {
+			var result User
+			schema.Parse(&result, syncMap, schema.NamingStrategy{IdentifierMaxLength: 64})
+		}()
+		go func() {
+			var result tests.Account
+			schema.Parse(&result, syncMap, schema.NamingStrategy{IdentifierMaxLength: 64})
+		}()
+	}
+}