File tree Expand file tree Collapse file tree 2 files changed +10
-10
lines changed Expand file tree Collapse file tree 2 files changed +10
-10
lines changed Original file line number Diff line number Diff line change @@ -158,10 +158,8 @@ func (p *Page) Navigate(url string) error {
158
158
url = "about:blank"
159
159
}
160
160
161
- err := p .StopLoading ()
162
- if err != nil {
163
- return err
164
- }
161
+ // try to stop loading
162
+ _ = p .StopLoading ()
165
163
166
164
res , err := proto.PageNavigate {URL : url }.Call (p )
167
165
if err != nil {
Original file line number Diff line number Diff line change @@ -670,13 +670,19 @@ func TestPagePDF(t *testing.T) {
670
670
})
671
671
}
672
672
673
- func TestPageNavigateErr (t * testing.T ) {
673
+ func TestPageNavigateDNSErr (t * testing.T ) {
674
674
g := setup (t )
675
+ p := g .newPage ()
675
676
676
677
// dns error
677
- err := g . page .Navigate ("http://" + g .RandStr (16 ))
678
+ err := p .Navigate ("http://" + g .RandStr (16 ))
678
679
g .Is (err , & rod.ErrNavigation {})
679
680
g .Is (err .Error (), "navigation failed: net::ERR_NAME_NOT_RESOLVED" )
681
+ p .MustNavigate ("about:blank" )
682
+ }
683
+
684
+ func TestPageNavigateErr (t * testing.T ) {
685
+ g := setup (t )
680
686
681
687
s := g .Serve ()
682
688
@@ -691,10 +697,6 @@ func TestPageNavigateErr(t *testing.T) {
691
697
g .page .MustNavigate (s .URL ("/404" ))
692
698
g .page .MustNavigate (s .URL ("/500" ))
693
699
694
- g .Panic (func () {
695
- g .mc .stubErr (1 , proto.PageStopLoading {})
696
- g .page .MustNavigate (g .blank ())
697
- })
698
700
g .Panic (func () {
699
701
g .mc .stubErr (1 , proto.PageNavigate {})
700
702
g .page .MustNavigate (g .blank ())
You can’t perform that action at this time.
0 commit comments