packets: do not call function on nulled value (#678)

julienschmidt · web-flow · commit fae512fbd064 · 2017-10-16T22:44:03.000+02:00
diff --git a/packets.go b/packets.go
@@ -1143,10 +1143,11 @@ func (rows *binaryRows) readRow(dest []driver.Value) error {
 			}
 			return io.EOF
 		}
+		mc := rows.mc
 		rows.mc = nil
 
 		// Error otherwise
-		return rows.mc.handleErrorPacket(data)
+		return mc.handleErrorPacket(data)
 	}
 
 	// NULL-bitmap,  [(column-count + 7 + 2) / 8 bytes]

Original file line number	Diff line number	Diff line change
`@@ -1143,10 +1143,11 @@ func (rows *binaryRows) readRow(dest []driver.Value) error {`
`1143`	`1143`	`}`
`1144`	`1144`	`return io.EOF`
`1145`	`1145`	`}`
	`1146`	`+ mc := rows.mc`
`1146`	`1147`	`rows.mc = nil`
`1147`	`1148`
`1148`	`1149`	`// Error otherwise`
`1149`		`- return rows.mc.handleErrorPacket(data)`
	`1150`	`+ return mc.handleErrorPacket(data)`
`1150`	`1151`	`}`
`1151`	`1152`
`1152`	`1153`	`// NULL-bitmap, [(column-count + 7 + 2) / 8 bytes]`