Merge pull request #579 from Fenny/master

Fenny · web-flow · commit a8ad5454363f · 2020-07-10T16:29:35.000-04:00
🐛 Escape fname
diff --git a/ctx.go b/ctx.go
@@ -196,7 +196,7 @@ func (ctx *Ctx) Attachment(filename ...string) {
 	if len(filename) > 0 {
 		fname := filepath.Base(filename[0])
 		ctx.Type(filepath.Ext(fname))
-		ctx.Set(HeaderContentDisposition, `attachment; filename="`+fname+`"`)
+		ctx.Set(HeaderContentDisposition, `attachment; filename="`+url.QueryEscape(fname)+`"`)
 		return
 	}
 	ctx.Set(HeaderContentDisposition, "attachment")

Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,7 @@ func (ctx *Ctx) Attachment(filename ...string) {`
`196`	`196`	`if len(filename) > 0 {`
`197`	`197`	`fname := filepath.Base(filename[0])`
`198`	`198`	`ctx.Type(filepath.Ext(fname))`
`199`		- ctx.Set(HeaderContentDisposition, `attachment; filename="`+fname+`"`)
	`199`	+ ctx.Set(HeaderContentDisposition, `attachment; filename="`+url.QueryEscape(fname)+`"`)
`200`	`200`	`return`
`201`	`201`	`}`
`202`	`202`	`ctx.Set(HeaderContentDisposition, "attachment")`