Skip to content

Commit 65d464f

Browse files
Merge branch 'master' into docs-add-development
* master: fix(chart): update rbac for F5 transportserver source (kubernetes-sigs#5066) fix(chart): non-string types on svcaccount annotations (kubernetes-sigs#5067)
2 parents f3d4156 + 070b2c5 commit 65d464f

File tree

4 files changed

+13
-3
lines changed

4 files changed

+13
-3
lines changed

charts/external-dns/CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1818

1919
## [UNRELEASED]
2020

21+
### Changed
22+
23+
- Added `transportservers` resource to ClusterRole when specifying `f5-transportserver` or `f5-virtualserver` as a source. ([#5066](https://github.com/kubernetes-sigs/external-dns/pull/5066)) _@visokoo_
24+
25+
### Fixed
26+
27+
- Fixed handling of non-string types in `serviceAccount.metadata.annotations` field. ([#5067](https://github.com/kubernetes-sigs/external-dns/pull/5067)) _@hjoshi123_
28+
2129
## [v1.15.1] - 2023-09-10
2230

2331
### Added

charts/external-dns/ci/ci-values.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,3 +40,5 @@ serviceAccount:
4040
notTemplated/version: "v1.2.3"
4141
justValueTemplated/version: "{{ .Chart.Version }}"
4242
"{{ .Chart.Name }}/chart": "{{ .Chart.Version }}"
43+
booleanVersion: "true"
44+
number: "1"

charts/external-dns/templates/clusterrole.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,9 @@ rules:
116116
resources: ["routegroups/status"]
117117
verbs: ["patch","update"]
118118
{{- end }}
119-
{{- if has "f5-virtualserver" .Values.sources }}
119+
{{- if or (has "f5-virtualserver" .Values.sources) (has "f5-transportserver" .Values.sources) }}
120120
- apiGroups: ["cis.f5.com"]
121-
resources: ["virtualservers"]
121+
resources: ["virtualservers", "transportservers"]
122122
verbs: ["get","watch","list"]
123123
{{- end }}
124124
{{- with .Values.rbac.additionalPermissions }}

charts/external-dns/templates/serviceaccount.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ metadata:
1212
{{- with .Values.serviceAccount.annotations }}
1313
annotations:
1414
{{- range $k, $v := . }}
15-
{{- printf "%s: %s" (tpl $k $) (tpl $v $) | nindent 4 }}
15+
{{- printf "%s: %s" (toYaml (tpl $k $)) (toYaml (tpl $v $)) | nindent 4 }}
1616
{{- end }}
1717
{{- end }}
1818
automountServiceAccountToken: {{ .Values.serviceAccount.automountServiceAccountToken }}

0 commit comments

Comments
 (0)