go1.24 support (#5224)

Author: ldez

.github/workflows/documentation.yml

@@ -16,7 +16,7 @@ jobs:
       # ex:
       # - 1.18beta1 -> 1.18.0-beta.1
       # - 1.18rc1 -> 1.18.0-rc.1
-      GO_VERSION: '1.23'
+      GO_VERSION: '1.24'
       NODE_VERSION: '20.x'
       CGO_ENABLED: 0
     steps:

.github/workflows/post-release.yml

@@ -9,7 +9,7 @@ env:
   # ex:
   # - 1.18beta1 -> 1.18.0-beta.1
   # - 1.18rc1 -> 1.18.0-rc.1
-  GO_VERSION: "1.23"
+  GO_VERSION: '1.24'
 
 jobs:
   update-gha-assets:

.github/workflows/pr-documentation.yml

@@ -13,7 +13,7 @@ jobs:
       # ex:
       # - 1.18beta1 -> 1.18.0-beta.1
       # - 1.18rc1 -> 1.18.0-rc.1
-      GO_VERSION: '1.23'
+      GO_VERSION: '1.24'
       NODE_VERSION: '20.x'
       CGO_ENABLED: 0
 

.github/workflows/pr.yml

@@ -11,7 +11,7 @@ env:
   # ex:
   # - 1.18beta1 -> 1.18.0-beta.1
   # - 1.18rc1 -> 1.18.0-rc.1
-  GO_VERSION: '1.23'
+  GO_VERSION: '1.24'
 
 jobs:
   # Check if there is any dirty change for go mod tidy
@@ -40,7 +40,9 @@ jobs:
           # ex:
           # - 1.18beta1 -> 1.18.0-beta.1
           # - 1.18rc1 -> 1.18.0-rc.1
-          go-version: ${{ env.GO_VERSION }}
+          # TODO(ldez) must be changed after the first release of golangci-lint with go1.24
+          # go-version: ${{ env.GO_VERSION }}
+          go-version: '1.23'
       - name: lint
         uses: golangci/golangci-lint-action@v6.3.2
         with:
@@ -76,8 +78,8 @@ jobs:
           - ubuntu-latest
           - ubuntu-24.04-arm
         golang:
-          - '1.22'
           - '1.23'
+          - '1.24'
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v4

.github/workflows/tag.yml

@@ -12,7 +12,7 @@ jobs:
       # ex:
       # - 1.18beta1 -> 1.18.0-beta.1
       # - 1.18rc1 -> 1.18.0-rc.1
-      GO_VERSION: '1.23'
+      GO_VERSION: '1.24'
       CHOCOLATEY_VERSION: 2.2.0
     steps:
       # temporary workaround for an error in free disk space action

.golangci.next.reference.yml

@@ -31,10 +31,8 @@ linters:
     - errchkjson
     - errname
     - errorlint
-    - execinquery
     - exhaustive
     - exhaustruct
-    - exportloopref
     - exptostd
     - fatcontext
     - forbidigo
@@ -149,10 +147,8 @@ linters:
     - errchkjson
     - errname
     - errorlint
-    - execinquery
     - exhaustive
     - exhaustruct
-    - exportloopref
     - exptostd
     - fatcontext
     - forbidigo
@@ -241,7 +237,9 @@ linters:
     - wsl
     - zerologlint
     - deadcode # Deprecated
+    - execinquery # Deprecated
     - exhaustivestruct # Deprecated
+    - exportloopref # Deprecated
     - golint # Deprecated
     - gomnd # Deprecated
     - ifshort # Deprecated

docs/src/docs/welcome/install.mdx

@@ -134,15 +134,15 @@ docker run -t --rm -v $(pwd):/app -w /app golangci/golangci-lint:{.LatestVersion
 
 ### Install from Sources
 
-Such `go install`/`go get` or "tools pattern" installations aren't guaranteed to work.
+Such `go install`/`go get`, "tools pattern", and `tool` command/directives installations aren't guaranteed to work.
 
 We recommend using binary installation.
 
 Those installations aren't recommended because of the following points:
 
 1. Those installations are compiling golangci-lint locally, the Go version used to build will depend on your local Go version.
 2. Some users use `-u` flag for `go get`, which upgrades our dependencies. Resulting binary was not tested and is not guaranteed to work.
-3. When using "tools pattern", the dependencies of a tool can modify the dependencies of another. Resulting binary was not tested and is not guaranteed to work.
+3. When using "tools pattern" or and `tool` command/directives, the dependencies of a tool can modify the dependencies of another or your project. Resulting binary was not tested and is not guaranteed to work.
 4. We've encountered issues with Go modules hashes due to unexpected recreation of dependency tags.
 5. `go.mod` replacement directives don't apply transitively. It means a user will be using patched version of `golangci-lint` if we use such replacements.
 6. It allows installation from main branch which can't be considered stable.

go.mod

@@ -1,6 +1,6 @@
 module github.com/golangci/golangci-lint
 
-go 1.22.1
+go 1.23.0
 
 require (
 	4d63.com/gocheckcompilerdirectives v1.2.1
@@ -63,7 +63,6 @@ require (
 	github.com/kkHAIKE/contextcheck v1.1.5
 	github.com/kulti/thelper v0.6.3
 	github.com/kunwardeep/paralleltest v1.0.10
-	github.com/kyoh86/exportloopref v0.1.11
 	github.com/lasiar/canonicalheader v1.1.2
 	github.com/ldez/exptostd v0.4.1
 	github.com/ldez/gomoddirectives v0.6.1
@@ -126,7 +125,6 @@ require (
 	go-simpler.org/musttag v0.13.0
 	go-simpler.org/sloglint v0.9.0
 	go.uber.org/automaxprocs v1.6.0
-	golang.org/x/exp v0.0.0-20240909161429-701f63a606c0
 	golang.org/x/mod v0.23.0
 	golang.org/x/sys v0.30.0
 	golang.org/x/tools v0.30.0
@@ -196,6 +194,7 @@ require (
 	go.uber.org/atomic v1.7.0 // indirect
 	go.uber.org/multierr v1.6.0 // indirect
 	go.uber.org/zap v1.24.0 // indirect
+	golang.org/x/exp v0.0.0-20240909161429-701f63a606c0 // indirect
 	golang.org/x/exp/typeparams v0.0.0-20241108190413-2d47ceb2692f // indirect
 	golang.org/x/sync v0.11.0 // indirect
 	golang.org/x/text v0.21.0 // indirect

go.sum

@@ -6,12 +6,12 @@ import (
 	"encoding/hex"
 	"errors"
 	"fmt"
+	"maps"
 	"runtime"
 	"slices"
 	"strings"
 	"sync"
 
-	"golang.org/x/exp/maps"
 	"golang.org/x/tools/go/packages"
 
 	"github.com/golangci/golangci-lint/internal/go/cache"
@@ -178,9 +178,7 @@ func (c *Cache) computePkgHash(pkg *packages.Package) (hashResults, error) {
 	curSum := key.Sum()
 	hashRes[HashModeNeedOnlySelf] = hex.EncodeToString(curSum[:])
 
-	imps := maps.Values(pkg.Imports)
-
-	slices.SortFunc(imps, func(a, b *packages.Package) int {
+	imps := slices.SortedFunc(maps.Values(pkg.Imports), func(a, b *packages.Package) int {
 		return strings.Compare(a.PkgPath, b.PkgPath)
 	})
 

internal/cache/cache.go

@@ -351,7 +351,6 @@
             "errorlint",
             "exhaustive",
             "exhaustruct",
-            "exportloopref",
             "exptostd",
             "fatcontext",
             "forbidigo",

jsonschema/golangci.next.jsonschema.json

@@ -8,12 +8,13 @@ import (
 	"fmt"
 	"io"
 	"log"
+	"maps"
 	"os"
 	"path/filepath"
 	"runtime"
 	"runtime/pprof"
 	"runtime/trace"
-	"sort"
+	"slices"
 	"strconv"
 	"strings"
 	"time"
@@ -24,7 +25,6 @@ import (
 	"github.com/spf13/pflag"
 	"github.com/spf13/viper"
 	"go.uber.org/automaxprocs/maxprocs"
-	"golang.org/x/exp/maps"
 	"gopkg.in/yaml.v3"
 
 	"github.com/golangci/golangci-lint/internal/cache"
@@ -452,8 +452,7 @@ func (c *runCommand) printStats(issues []result.Issue) {
 
 	c.cmd.Printf("%d issues:\n", len(issues))
 
-	keys := maps.Keys(stats)
-	sort.Strings(keys)
+	keys := slices.Sorted(maps.Keys(stats))
 
 	for _, key := range keys {
 		c.cmd.Printf("* %s: %d\n", key, stats[key])

pkg/commands/run.go

@@ -8,11 +8,11 @@ import (
 	"encoding/gob"
 	"fmt"
 	"go/token"
+	"maps"
 	"runtime"
-	"sort"
+	"slices"
 	"sync"
 
-	"golang.org/x/exp/maps"
 	"golang.org/x/tools/go/analysis"
 	"golang.org/x/tools/go/packages"
 
@@ -159,8 +159,8 @@ func (r *runner) buildActionFactDeps(act *action, a *analysis.Analyzer, pkg *pac
 	act.objectFacts = make(map[objectFactKey]analysis.Fact)
 	act.packageFacts = make(map[packageFactKey]analysis.Fact)
 
-	paths := maps.Keys(pkg.Imports)
-	sort.Strings(paths) // for determinism
+	paths := slices.Sorted(maps.Keys(pkg.Imports)) // for determinism
+
 	for _, path := range paths {
 		dep := r.makeAction(a, pkg.Imports[path], initialPkgs, actions, actAlloc)
 		act.Deps = append(act.Deps, dep)
@@ -209,7 +209,7 @@ func (r *runner) prepareAnalysis(pkgs []*packages.Package,
 		}
 	}
 
-	allActions = maps.Values(actions)
+	allActions = slices.Collect(maps.Values(actions))
 
 	debugf("Built %d actions", len(actions))
 

pkg/goanalysis/runner.go

@@ -5,17 +5,16 @@ import (
 	"fmt"
 	"go/ast"
 	"go/types"
+	"maps"
 	"reflect"
 	"runtime"
 	"slices"
-	"sort"
 	"strings"
 	"sync"
 
 	"github.com/go-critic/go-critic/checkers"
 	gocriticlinter "github.com/go-critic/go-critic/linter"
 	_ "github.com/quasilyte/go-ruleguard/dsl"
-	"golang.org/x/exp/maps"
 	"golang.org/x/tools/go/analysis"
 
 	"github.com/golangci/golangci-lint/pkg/config"
@@ -168,8 +167,7 @@ func (w *goCriticWrapper) configureCheckerInfo(
 				info.Name, k)
 		}
 
-		supportedKeys := maps.Keys(info.Params)
-		sort.Strings(supportedKeys)
+		supportedKeys := slices.Sorted(maps.Keys(info.Params))
 
 		return fmt.Errorf("checker %s config param %s doesn't exist, all existing: %s",
 			info.Name, k, supportedKeys)
@@ -270,8 +268,7 @@ func newSettingsWrapper(settings *config.GoCriticSettings, logger logutils.Log)
 		}
 	}
 
-	allTagsSorted := maps.Keys(allChecksByTag)
-	sort.Strings(allTagsSorted)
+	allTagsSorted := slices.Sorted(maps.Keys(allChecksByTag))
 
 	return &settingsWrapper{
 		GoCriticSettings:                settings,
@@ -558,8 +555,7 @@ func debugChecksListf(checks []string, format string, args ...any) {
 		return
 	}
 
-	v := slices.Clone(checks)
-	slices.Sort(v)
+	v := slices.Sorted(slices.Values(checks))
 
 	debugf("%s checks (%d): %s", fmt.Sprintf(format, args...), len(checks), strings.Join(v, ", "))
 }

pkg/golinters/exportloopref/exportloopref.go

@@ -1,6 +1,7 @@
 package gocritic
 
 import (
+	"maps"
 	"slices"
 	"strings"
 	"testing"
@@ -9,7 +10,6 @@ import (
 	gocriticlinter "github.com/go-critic/go-critic/linter"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"golang.org/x/exp/maps"
 
 	"github.com/golangci/golangci-lint/pkg/config"
 	"github.com/golangci/golangci-lint/pkg/logutils"
@@ -40,7 +40,7 @@ func Test_settingsWrapper_InferEnabledChecks(t *testing.T) {
 	t.Logf("enabled by default checks:\n%s", strings.Join(enabledByDefaultChecks, "\n"))
 
 	insert := func(in []string, toInsert ...string) []string {
-		return append(slices.Clone(in), toInsert...)
+		return slices.Concat(in, toInsert)
 	}
 
 	remove := func(in []string, toRemove ...string) []string {
@@ -54,9 +54,7 @@ func Test_settingsWrapper_InferEnabledChecks(t *testing.T) {
 	}
 
 	uniq := func(in []string) []string {
-		result := slices.Clone(in)
-		slices.Sort(result)
-		return slices.Compact(result)
+		return slices.Compact(slices.Sorted(slices.Values(in)))
 	}
 
 	cases := []struct {
@@ -269,7 +267,7 @@ func Test_settingsWrapper_InferEnabledChecks(t *testing.T) {
 			wr := newSettingsWrapper(tt.sett, lg)
 
 			wr.InferEnabledChecks()
-			assert.ElementsMatch(t, tt.expectedEnabledChecks, maps.Keys(wr.inferredEnabledChecks))
+			assert.ElementsMatch(t, tt.expectedEnabledChecks, slices.Collect(maps.Keys(wr.inferredEnabledChecks)))
 			assert.NoError(t, wr.Validate())
 		})
 	}

pkg/golinters/exportloopref/exportloopref_integration_test.go

@@ -9,7 +9,7 @@ import (
 )
 
 func GovetComposites() error {
-	return &os.PathError{"first", "path", os.ErrNotExist} // want "composites: io/fs\\.PathError struct literal uses unkeyed fields"
+	return &os.PathError{"first", "path", os.ErrNotExist} // want "composites: (os|io/fs)\\.PathError struct literal uses unkeyed fields"
 }
 
 func GovetShadow(f io.Reader, buf []byte) (err error) {

pkg/golinters/exportloopref/testdata/exportloopref.go

@@ -1,10 +1,11 @@
 package thelper
 
 import (
+	"maps"
+	"slices"
 	"strings"
 
 	"github.com/kulti/thelper/pkg/analyzer"
-	"golang.org/x/exp/maps"
 	"golang.org/x/tools/go/analysis"
 
 	"github.com/golangci/golangci-lint/pkg/config"
@@ -44,7 +45,7 @@ func New(settings *config.ThelperSettings) *goanalysis.Linter {
 		internal.LinterLogger.Fatalf("thelper: at least one option must be enabled")
 	}
 
-	args := maps.Keys(opts)
+	args := slices.Collect(maps.Keys(opts))
 
 	cfg := map[string]map[string]any{
 		a.Name: {

pkg/golinters/exportloopref/testdata/exportloopref_cgo.go

@@ -26,7 +26,7 @@ func Test_osMkdirTemp(t *testing.T) {
 }
 
 func Test_osSetenv(t *testing.T) {
-	os.Setenv("", "")
+	os.Setenv("", "") // want `os\.Setenv\(\) could be replaced by t\.Setenv\(\) in .+`
 }
 
 func Test_osTempDir(t *testing.T) {

pkg/golinters/gocritic/gocritic.go

@@ -167,10 +167,6 @@ func IsGoLowerThanGo122() func(cfg *config.Config) error {
 	return isGoLowerThanGo("1.22")
 }
 
-func IsGoLowerThanGo124() func(cfg *config.Config) error {
-	return isGoLowerThanGo("1.24")
-}
-
 func isGoLowerThanGo(v string) func(cfg *config.Config) error {
 	return func(cfg *config.Config) error {
 		if cfg == nil || config.IsGoGreaterThanOrEqual(cfg.Run.Go, v) {

pkg/golinters/gocritic/gocritic_test.go

@@ -25,7 +25,6 @@ import (
 	"github.com/golangci/golangci-lint/pkg/golinters/errorlint"
 	"github.com/golangci/golangci-lint/pkg/golinters/exhaustive"
 	"github.com/golangci/golangci-lint/pkg/golinters/exhaustruct"
-	"github.com/golangci/golangci-lint/pkg/golinters/exportloopref"
 	"github.com/golangci/golangci-lint/pkg/golinters/exptostd"
 	"github.com/golangci/golangci-lint/pkg/golinters/fatcontext"
 	"github.com/golangci/golangci-lint/pkg/golinters/forbidigo"
@@ -278,12 +277,12 @@ func (LinterBuilder) Build(cfg *config.Config) ([]*linter.Config, error) {
 			WithLoadForGoAnalysis().
 			WithURL("https://github.com/GaijinEntertainment/go-exhaustruct"),
 
-		linter.NewConfig(exportloopref.New()).
+		linter.NewConfig(linter.NewNoopDeprecated("exportloopref", cfg, linter.DeprecationError)).
 			WithSince("v1.28.0").
 			WithPresets(linter.PresetBugs).
 			WithLoadForGoAnalysis().
 			WithURL("https://github.com/kyoh86/exportloopref").
-			DeprecatedWarning("Since Go1.22 (loopvar) this linter is no longer relevant.", "v1.60.2", "copyloopvar"),
+			DeprecatedError("Since Go1.22 (loopvar) this linter is no longer relevant.", "v1.60.2", "copyloopvar"),
 
 		linter.NewConfig(exptostd.New()).
 			WithSince("v1.63.0").

pkg/golinters/govet/testdata/govet.go

@@ -2,11 +2,11 @@ package lintersdb
 
 import (
 	"fmt"
+	"maps"
 	"os"
 	"slices"
 	"sort"
-
-	"golang.org/x/exp/maps"
+	"strings"
 
 	"github.com/golangci/golangci-lint/pkg/config"
 	"github.com/golangci/golangci-lint/pkg/goanalysis"
@@ -109,24 +109,25 @@ func (m *Manager) GetOptimizedLinters() ([]*linter.Config, error) {
 
 	m.combineGoAnalysisLinters(resultLintersSet)
 
-	resultLinters := maps.Values(resultLintersSet)
-
 	// Make order of execution of linters (go/analysis metalinter and unused) stable.
-	sort.Slice(resultLinters, func(i, j int) bool {
-		a, b := resultLinters[i], resultLinters[j]
-
+	resultLinters := slices.SortedFunc(maps.Values(resultLintersSet), func(a *linter.Config, b *linter.Config) int {
 		if b.Name() == linter.LastLinter {
-			return true
+			return -1
 		}
 
 		if a.Name() == linter.LastLinter {
-			return false
+			return 1
 		}
 
 		if a.DoesChangeTypes != b.DoesChangeTypes {
-			return b.DoesChangeTypes // move type-changing linters to the end to optimize speed
+			// move type-changing linters to the end to optimize speed
+			if b.DoesChangeTypes {
+				return -1
+			}
+			return 1
 		}
-		return a.Name() < b.Name()
+
+		return strings.Compare(a.Name(), b.Name())
 	})
 
 	return resultLinters, nil

pkg/golinters/thelper/thelper.go

@@ -4,10 +4,11 @@ import (
 	"encoding/xml"
 	"fmt"
 	"io"
-	"sort"
+	"maps"
+	"slices"
+	"strings"
 
 	"github.com/go-xmlfmt/xmlfmt"
-	"golang.org/x/exp/maps"
 
 	"github.com/golangci/golangci-lint/pkg/logutils"
 	"github.com/golangci/golangci-lint/pkg/result"
@@ -70,10 +71,8 @@ func (p *Checkstyle) Print(issues []result.Issue) error {
 		p.log.Infof("%v", err)
 	}
 
-	out.Files = maps.Values(files)
-
-	sort.Slice(out.Files, func(i, j int) bool {
-		return out.Files[i].Name < out.Files[j].Name
+	out.Files = slices.SortedFunc(maps.Values(files), func(a *checkstyleFile, b *checkstyleFile) int {
+		return strings.Compare(a.Name, b.Name)
 	})
 
 	data, err := xml.Marshal(&out)

pkg/golinters/usetesting/testdata/usetesting_go124.go

@@ -4,11 +4,10 @@ import (
 	"encoding/xml"
 	"fmt"
 	"io"
-	"sort"
+	"maps"
+	"slices"
 	"strings"
 
-	"golang.org/x/exp/maps"
-
 	"github.com/golangci/golangci-lint/pkg/result"
 )
 
@@ -60,10 +59,9 @@ func (p JUnitXML) Print(issues []result.Issue) error {
 	}
 
 	var res testSuitesXML
-	res.TestSuites = maps.Values(suites)
 
-	sort.Slice(res.TestSuites, func(i, j int) bool {
-		return res.TestSuites[i].Suite < res.TestSuites[j].Suite
+	res.TestSuites = slices.SortedFunc(maps.Values(suites), func(a testSuiteXML, b testSuiteXML) int {
+		return strings.Compare(a.Suite, b.Suite)
 	})
 
 	enc := xml.NewEncoder(p.w)

pkg/lint/linter/config.go

@@ -9,11 +9,10 @@ package processors
 import (
 	"errors"
 	"fmt"
+	"maps"
 	"os"
 	"slices"
 
-	"golang.org/x/exp/maps"
-
 	"github.com/golangci/golangci-lint/internal/x/tools/diff"
 	"github.com/golangci/golangci-lint/pkg/config"
 	"github.com/golangci/golangci-lint/pkg/fsutils"
@@ -126,7 +125,7 @@ func (p Fixer) process(issues []result.Issue) ([]result.Issue, error) {
 	for path, linterToEdits := range editsByLinter {
 		excludedLinters := make(map[string]struct{})
 
-		linters := maps.Keys(linterToEdits)
+		linters := slices.Collect(maps.Keys(linterToEdits))
 
 		// Does any linter create conflicting edits?
 		for _, linter := range linters {

pkg/lint/lintersdb/builder_linter.go

@@ -4,12 +4,12 @@ import (
 	"go/ast"
 	"go/parser"
 	"go/token"
+	"maps"
 	"regexp"
+	"slices"
 	"sort"
 	"strings"
 
-	"golang.org/x/exp/maps"
-
 	"github.com/golangci/golangci-lint/pkg/golinters/nolintlint"
 	"github.com/golangci/golangci-lint/pkg/lint/linter"
 	"github.com/golangci/golangci-lint/pkg/lint/lintersdb"
@@ -102,8 +102,7 @@ func (p *NolintFilter) Finish() {
 		return
 	}
 
-	unknownLinters := maps.Keys(p.unknownLintersSet)
-	sort.Strings(unknownLinters)
+	unknownLinters := slices.Sorted(maps.Keys(p.unknownLintersSet))
 
 	p.log.Warnf("Found unknown linters in //nolint directives: %s", strings.Join(unknownLinters, ", "))
 }

pkg/lint/lintersdb/manager.go

@@ -6,7 +6,6 @@ import (
 	"log"
 	"os"
 	"path/filepath"
-	"strings"
 
 	hcversion "github.com/hashicorp/go-version"
 
@@ -28,25 +27,21 @@ func copySchemas() error {
 		return fmt.Errorf("remove dir: %w", err)
 	}
 
-	err = os.MkdirAll(dstDir, os.ModePerm)
+	err = os.CopyFS(dstDir, os.DirFS("jsonschema"))
 	if err != nil {
-		return fmt.Errorf("make dir: %w", err)
+		return fmt.Errorf("copy FS: %w", err)
 	}
 
-	// The key is the destination file.
-	// The value is the source file.
-	files := map[string]string{}
-
-	entries, err := os.ReadDir("jsonschema")
+	err = copyLatestSchema()
 	if err != nil {
-		return fmt.Errorf("read dir: %w", err)
+		return fmt.Errorf("copy files: %w", err)
 	}
 
-	for _, entry := range entries {
-		if strings.HasSuffix(entry.Name(), ".jsonschema.json") {
-			files[entry.Name()] = entry.Name()
-		}
-	}
+	return nil
+}
+
+func copyLatestSchema() error {
+	src := filepath.FromSlash("jsonschema/golangci.jsonschema.json")
 
 	latest, err := github.GetLatestVersion()
 	if err != nil {
@@ -58,20 +53,11 @@ func copySchemas() error {
 		return fmt.Errorf("parse version: %w", err)
 	}
 
-	versioned := fmt.Sprintf("golangci.v%d.%d.jsonschema.json", version.Segments()[0], version.Segments()[1])
-	files[versioned] = "golangci.jsonschema.json"
-
-	for dst, src := range files {
-		err := copyFile(filepath.Join("jsonschema", src), filepath.Join(dstDir, dst))
-		if err != nil {
-			return fmt.Errorf("copy files: %w", err)
-		}
+	files := []string{
+		fmt.Sprintf("golangci.v%d.jsonschema.json", version.Segments()[0]),
+		fmt.Sprintf("golangci.v%d.%d.jsonschema.json", version.Segments()[0], version.Segments()[1]),
 	}
 
-	return nil
-}
-
-func copyFile(src, dst string) error {
 	source, err := os.Open(src)
 	if err != nil {
 		return fmt.Errorf("open file %s: %w", src, err)
@@ -84,6 +70,17 @@ func copyFile(src, dst string) error {
 		return fmt.Errorf("file %s not found: %w", src, err)
 	}
 
+	for _, dst := range files {
+		err = copyFile(dst, source, info)
+		if err != nil {
+			return fmt.Errorf("copy file %s to %s: %w", src, dst, err)
+		}
+	}
+
+	return nil
+}
+
+func copyFile(dst string, source io.Reader, info os.FileInfo) error {
 	destination, err := os.OpenFile(dst, os.O_RDWR|os.O_CREATE|os.O_TRUNC, info.Mode())
 	if err != nil {
 		return fmt.Errorf("create file %s: %w", dst, err)
@@ -93,7 +90,7 @@ func copyFile(src, dst string) error {
 
 	_, err = io.Copy(destination, source)
 	if err != nil {
-		return fmt.Errorf("copy file %s to %s: %w", src, dst, err)
+		return err
 	}
 
 	return nil

pkg/printers/checkstyle.go

@@ -2,11 +2,10 @@ package main
 
 import (
 	"fmt"
-	"sort"
+	"maps"
+	"slices"
 	"strings"
 
-	"golang.org/x/exp/maps"
-
 	"github.com/golangci/golangci-lint/pkg/config"
 	"github.com/golangci/golangci-lint/pkg/lint/linter"
 	"github.com/golangci/golangci-lint/pkg/lint/lintersdb"
@@ -69,9 +68,8 @@ func getThanksList() string {
 		}
 	}
 
-	authors := maps.Keys(addedAuthors)
-	sort.Slice(authors, func(i, j int) bool {
-		return strings.ToLower(authors[i]) < strings.ToLower(authors[j])
+	authors := slices.SortedFunc(maps.Keys(addedAuthors), func(a string, b string) int {
+		return strings.Compare(strings.ToLower(a), strings.ToLower(b))
 	})
 
 	lines := []string{