Skip to content
This repository was archived by the owner on Aug 1, 2024. It is now read-only.

Commit 3e83d96

Browse files
Closure Teamcopybara-github
authored andcommitted
Remove configurability for whether noreferrer implies noopener
RELNOTES[INC]: Remove configurability for whether window.open with noreferrer implies noopener PiperOrigin-RevId: 467259786 Change-Id: Ic07e344977d642a67283e6da7c0255fecbf0c86e
1 parent b811be0 commit 3e83d96

File tree

2 files changed

+1
-59
lines changed

2 files changed

+1
-59
lines changed

closure/goog/window/window.js

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -54,27 +54,6 @@ goog.window.createFakeWindow_ = function() {
5454
return /** @type {!Window} */ ({});
5555
};
5656

57-
/**
58-
* @define {boolean} Whether setting 'noreferrer' implies 'noopener'. Ultimately
59-
* we aim to make this true by default.
60-
*/
61-
goog.window.NOREFERRER_IMPLIES_NOOPENER =
62-
goog.define('goog.window.NOREFERRER_IMPLIES_NOOPENER', true);
63-
64-
/**
65-
* @const forTesting contains a map used for overriding goog.defines for
66-
* testing purposes.
67-
*/
68-
goog.window.forTesting = {};
69-
70-
/**
71-
* @type {boolean} An overridable copy of
72-
* goog.window.NOREFERRER_IMPLIES_NOOPENER.
73-
*/
74-
goog.window.forTesting.noreferrerImpliesNoopener =
75-
goog.window.NOREFERRER_IMPLIES_NOOPENER;
76-
77-
7857
/**
7958
* Opens a new window.
8059
*
@@ -315,8 +294,7 @@ goog.window.open = function(linkRef, opt_options, opt_parentWin) {
315294
// we're already running on a modern enough browser that the referrer is
316295
// hidden by default. But setting noreferrer implies noopener too, so we
317296
// also have to clear the opener here.
318-
if (goog.window.forTesting.noreferrerImpliesNoopener && newWin &&
319-
opt_options['noreferrer']) {
297+
if (newWin && opt_options['noreferrer']) {
320298
newWin.opener = null;
321299
}
322300
}

closure/goog/window/window_test.js

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,6 @@ testSuite({
144144

145145
setUp() {
146146
newWin = null;
147-
googWindow.forTesting.noreferrerImpliesNoopener = true;
148147
},
149148

150149
tearDown() {
@@ -516,39 +515,4 @@ testSuite({
516515
assertEquals('', openedUrl);
517516
}
518517
},
519-
520-
521-
testOpenNewWindowNoreferrerImpliesNoopenerDisabled() {
522-
googWindow.forTesting.noreferrerImpliesNoopener = false;
523-
524-
let documentWriteHtml;
525-
let openedUrl;
526-
const mockNewWin = {};
527-
mockNewWin.document = {
528-
write: function(html) {
529-
documentWriteHtml = html;
530-
},
531-
close: function() {},
532-
};
533-
const /** ? */ mockWin = {
534-
open: function(url) {
535-
openedUrl = url;
536-
return mockNewWin;
537-
},
538-
};
539-
mockNewWin.opener = mockWin;
540-
const options = {noreferrer: true};
541-
const win = googWindow.open('https://example.com', options, mockWin);
542-
if (self.crossOriginIsolated !== undefined) {
543-
assertEquals(undefined, documentWriteHtml);
544-
assertEquals('https://example.com', openedUrl);
545-
assertNotNull(win.opener);
546-
} else {
547-
assertEquals(
548-
'<meta name="referrer" content="no-referrer"><meta http-equiv="refresh" content="0; url=https://example.com">',
549-
documentWriteHtml);
550-
assertEquals('', openedUrl);
551-
assertNull(win.opener);
552-
}
553-
},
554518
});

0 commit comments

Comments
 (0)