Disable the Closure Debug Loader by default.

lukesandberg · copybara-github · commit b12e80d1e0af · 2023-03-01T17:18:42.000-08:00
This is being done because pre-bundling code is always a superior strategy and when bundling the debug loader is not needed. Having the loader enabled may hide misconfigurations or log unactionable warnings.  This will eventually make it possible to move the debug loader out of base.js and drop all the associate code from development scenarios.

RELNOTES: Disable the Closure Debug Loader by default.
PiperOrigin-RevId: 513384198
Change-Id: I85571d2781a96c89f1e39466d76ed353d19024c3
diff --git a/closure/goog/base.js b/closure/goog/base.js
@@ -786,7 +786,7 @@ goog.addDependency = function(relPath, provides, requires, opt_loadFlags) {
  * provided (and depend on the fact that some outside tool correctly ordered
  * the script).
  */
-goog.ENABLE_DEBUG_LOADER = goog.define('goog.ENABLE_DEBUG_LOADER', true);
+goog.ENABLE_DEBUG_LOADER = goog.define('goog.ENABLE_DEBUG_LOADER', false);
 
 
 /**
diff --git a/closure/goog/messaging/testdata/portchannel_inner.html b/closure/goog/messaging/testdata/portchannel_inner.html
@@ -8,6 +8,10 @@
 -->
 <head>
 <title>PortChannel test inner document</title>
+<script>
+  var CLOSURE_DEFINES = CLOSURE_DEFINES || {};
+  CLOSURE_DEFINES["goog.ENABLE_DEBUG_LOADER"]=true;
+</script>
 
 <!-- MOE:insert <script src="../../base.js"></script> -->
 <script>
diff --git a/closure/goog/messaging/testdata/portchannel_worker.js b/closure/goog/messaging/testdata/portchannel_worker.js
@@ -16,6 +16,8 @@
 self.CLOSURE_BASE_PATH =
 self.CLOSURE_BASE_PATH = '../../';
 importScripts('../../bootstrap/webworkers.js');
+self.CLOSURE_DEFINES = self.CLOSURE_DEFINES || {};
+self.CLOSURE_DEFINES['goog.ENABLE_DEBUG_LOADER'] = true;
 importScripts('../../base.js');
 
 // The provide is necessary to stop the jscompiler from thinking this is an
diff --git a/closure/goog/messaging/testdata/portchannel_wrong_origin_inner.html b/closure/goog/messaging/testdata/portchannel_wrong_origin_inner.html
@@ -8,7 +8,11 @@
 -->
 <head>
 <title>PortChannel test inner document</title>
-<script src="../../base.js"></script>
+<script>
+  var CLOSURE_DEFINES = CLOSURE_DEFINES || {};
+  CLOSURE_DEFINES["goog.ENABLE_DEBUG_LOADER"]=true;
+</script>
+<script src="../../../../../javascript/closure/base.js"></script>
 <script>
 goog.require('goog.messaging.PortChannel');
 </script>
diff --git a/closure/goog/messaging/testdata/portnetwork_inner.html b/closure/goog/messaging/testdata/portnetwork_inner.html
@@ -10,6 +10,10 @@
 <title>
   Closure Unit Tests - goog.messaging.PortNetwork iframe page
 </title>
+<script>
+  var CLOSURE_DEFINES = CLOSURE_DEFINES || {};
+  CLOSURE_DEFINES["goog.ENABLE_DEBUG_LOADER"]=true;
+</script>
 
 <!-- MOE:insert <script src="../../base.js"></script> -->
 <script>
diff --git a/closure/goog/messaging/testdata/portnetwork_worker1.js b/closure/goog/messaging/testdata/portnetwork_worker1.js
@@ -15,6 +15,8 @@
 
 self.CLOSURE_BASE_PATH =
 self.CLOSURE_BASE_PATH = '../../';
+self.CLOSURE_DEFINES = self.CLOSURE_DEFINES || {};
+self.CLOSURE_DEFINES['goog.ENABLE_DEBUG_LOADER'] = true;
 importScripts('../../bootstrap/webworkers.js');
 importScripts('../../base.js');
 
diff --git a/closure/goog/messaging/testdata/portnetwork_worker2.js b/closure/goog/messaging/testdata/portnetwork_worker2.js
@@ -16,6 +16,8 @@
 self.CLOSURE_BASE_PATH =
 self.CLOSURE_BASE_PATH = '../../';
 importScripts('../../bootstrap/webworkers.js');
+self.CLOSURE_DEFINES = self.CLOSURE_DEFINES || {};
+self.CLOSURE_DEFINES['goog.ENABLE_DEBUG_LOADER'] = true;
 importScripts('../../base.js');
 
 // The provide is necessary to stop the jscompiler from thinking this is an
diff --git a/closure/goog/net/crossdomainrpc_test_response.html b/closure/goog/net/crossdomainrpc_test_response.html
@@ -15,6 +15,10 @@
 -->
 <title>crossdomainrpc test response</title>
 <body>
+<script>
+  var CLOSURE_DEFINES = CLOSURE_DEFINES || {};
+  CLOSURE_DEFINES["goog.ENABLE_DEBUG_LOADER"]=true;
+</script>
 <!-- MOE:begin_strip -->
 <script src="../../../../javascript/closure/base.js"></script>
 <!-- MOE:end_strip_and_replace
diff --git a/closure/goog/net/xpc/testdata/inner_peer.html b/closure/goog/net/xpc/testdata/inner_peer.html
@@ -16,6 +16,10 @@
 
 <head>
 <title>XPC test inner frame</title>
+<script>
+  var CLOSURE_DEFINES = CLOSURE_DEFINES || {};
+  CLOSURE_DEFINES["goog.ENABLE_DEBUG_LOADER"] = true;
+</script>
 <!-- MOE:begin_strip -->
 <script src="../../../../../../javascript/closure/base.js"></script>
 <!-- MOE:end_strip_and_replace
