Skip to content

test: rename scan image JSON format cases#2024

Merged
hogo6002 merged 1 commit into
google:mainfrom
ackama:test/rename
Jul 7, 2025
Merged

test: rename scan image JSON format cases#2024
hogo6002 merged 1 commit into
google:mainfrom
ackama:test/rename

Conversation

@G-Rath
Copy link
Copy Markdown
Collaborator

@G-Rath G-Rath commented Jul 7, 2025

Only one of these tests actually uses --all-packages but they all output in JSON format so I think this is a better name and that also means its reasonable for us to add more cases such as in #2021

@G-Rath G-Rath marked this pull request as ready for review July 7, 2025 03:49
@G-Rath G-Rath requested review from another-rex, cuixq and hogo6002 July 7, 2025 03:49
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.02%. Comparing base (4f1b54b) to head (6e2a8b4).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2024   +/-   ##
=======================================
  Coverage   66.02%   66.02%           
=======================================
  Files         172      172           
  Lines       16222    16222           
=======================================
  Hits        10710    10710           
  Misses       4857     4857           
  Partials      655      655           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@G-Rath
Copy link
Copy Markdown
Collaborator Author

G-Rath commented Jul 7, 2025

@another-rex it happened in CI! (cli v3 nil pointer panic)

image

@hogo6002 hogo6002 enabled auto-merge (squash) July 7, 2025 05:19
@hogo6002 hogo6002 merged commit dbac12e into google:main Jul 7, 2025
28 of 29 checks passed
@hogo6002 hogo6002 deleted the test/rename branch July 7, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants