test(output): make paths absolute#2034
Conversation
c0166de to
ffe6a69
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2034 +/- ##
==========================================
- Coverage 66.09% 66.07% -0.02%
==========================================
Files 172 172
Lines 16214 16214
==========================================
- Hits 10716 10713 -3
- Misses 4848 4850 +2
- Partials 650 651 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9824188 to
f35f535
Compare
|
@another-rex so I think I've got this sorted for the This seems to be by design e.g. for That shouldn't be a blocker for this though so I can create an issue and we can go from there - there's also the question on if we want to include any runtime or test-only checks to help catch this in future (since I'm about to remove the check, here's a link to the run: https://github.com/google/osv-scanner/actions/runs/16154653469/job/45594387172?pr=2034) |
e7f2858 to
d95a0c8
Compare
d95a0c8 to
774edaa
Compare
|
It should be a simple fix, as all container scanning should be relative to root, we just need to add a loop in ScanContainer to add |
|
Or try setting StoreAbsolutePath to be true in the config for ScanContainer() call. |
774edaa to
332246b
Compare
|
Need to merge and rerun the snapshots, because of #2064 |
332246b to
10df4ac
Compare

We expect the source information given to
outputto always be an absolute path, but our internal fixtures are currently using relative paths, so this changes that.Note that this is about making the existing snapshots accurate to our current output even if that isn't something we like - if anyone feels something should be changed as a result of this, please file an issue