feat: fall back to offline extractor if the transitive one fails#2079
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2079 +/- ##
==========================================
- Coverage 67.49% 67.46% -0.04%
==========================================
Files 172 172
Lines 16240 16273 +33
==========================================
+ Hits 10961 10978 +17
- Misses 4603 4618 +15
- Partials 676 677 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@another-rex @G-Rath can you take a look on this PR see if this looks reasonable to you? thanks. |
G-Rath
left a comment
There was a problem hiding this comment.
this looks fine, though I think it speaks to how useful it'd be to have enrichers supported 😅
|
@cuixq is it possible this introduced a bug? Please see my question here: #2163. In the discussion attached there is the As a result in V2.1 the run fails. In v2.2 it doesn't fail no more, but it also doesn't list the other vulnerabilities any more. |
|
@moritzschmitz-oviva I replied to that question before seeing the comment here so I copied the information there. I will post my replies in that thread! |
#2077
Currently, if the extractor is enhanced but the extraction failed, no result will be returned. A better user experience is to fall back to the offline extractor so at least the direct dependencies are returned.