refactor(models): remove unneeded group IDs length check#2093
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2093 +/- ##
==========================================
+ Coverage 67.56% 67.60% +0.03%
==========================================
Files 173 173
Lines 16326 16318 -8
==========================================
Hits 11031 11031
+ Misses 4618 4612 -6
+ Partials 677 675 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
another-rex
approved these changes
Jul 21, 2025
another-rex
added a commit
that referenced
this pull request
Jul 21, 2025
Also added a test for No vulnerabilities but with license violations. (about #2093, it looks like this doesn't actually trigger the removed codepath either suprisingly)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These branches are not covered by our test suite indicating we've either got some missing cases or they're not actually needed - I'm betting on it being the latter, and if I'm wrong then we'll have found a hole