fix: pass through plugin capabilities#2095
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2095 +/- ##
==========================================
+ Coverage 67.56% 67.60% +0.04%
==========================================
Files 173 173
Lines 16326 16319 -7
==========================================
+ Hits 11031 11033 +2
+ Misses 4618 4611 -7
+ Partials 677 675 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cuixq
approved these changes
Jul 21, 2025
Comment on lines
+343
to
+348
| capabilities := &plugin.Capabilities{ | ||
| DirectFS: true, | ||
| RunningSystem: false, | ||
| OS: plugin.OSLinux, | ||
| }) | ||
| } | ||
| plugins = plugin.FilterByCapabilities(plugins, capabilities) |
Contributor
There was a problem hiding this comment.
does this make any functional change?
Collaborator
Author
There was a problem hiding this comment.
Because we are filtering already, it doesn't really change anything functional.
G-Rath
approved these changes
Jul 21, 2025
| Exit: 1, | ||
| }, | ||
| { | ||
| Name: "No vulnerabilities but license violations with allowlist", |
Collaborator
There was a problem hiding this comment.
I think this is still good to have but fyi we've already got this covered with "some packages with license violations in json" about 4 cases down, which is why #2093 doesn't get covered by this 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added a test for No vulnerabilities but with license violations. (about #2093, it looks like this doesn't actually trigger the removed codepath either suprisingly)