Skip to content

fix: osv-scanner json scans not matching with correct ecosystem#2141

Merged
another-rex merged 2 commits into
google:mainfrom
another-rex:fix-osvscanner.json-scans
Aug 6, 2025
Merged

fix: osv-scanner json scans not matching with correct ecosystem#2141
another-rex merged 2 commits into
google:mainfrom
another-rex:fix-osvscanner.json-scans

Conversation

@another-rex
Copy link
Copy Markdown
Collaborator

@another-rex another-rex commented Aug 5, 2025

Fixes #2139

Since osv-scalibr updated how Ecosystem is returned to be centralized, we need to add our own check in imodels to return the correct ecosystem.

Also:

  • Removed extra functions in the extractor that's no longer needed
  • Added a test for the regression.

@another-rex another-rex changed the title Fix osv-scanner json scans fix: osv-scanner json scans not matching with correct ecosystem Aug 5, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.54%. Comparing base (0063082) to head (82dc63f).
⚠️ Report is 403 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2141      +/-   ##
==========================================
+ Coverage   67.49%   67.54%   +0.04%     
==========================================
  Files         171      171              
  Lines       16258    16255       -3     
==========================================
+ Hits        10974    10980       +6     
+ Misses       4608     4600       -8     
+ Partials      676      675       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@another-rex another-rex merged commit 92c97b1 into google:main Aug 6, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression for pkg:golang/toolchain and pkg:golang/stdlib since 2.0.3

3 participants