Skip to content

test: always use a unique directory for local advisory cases#2451

Merged
G-Rath merged 1 commit into
google:mainfrom
ackama:always-use-unique-path
Jan 9, 2026
Merged

test: always use a unique directory for local advisory cases#2451
G-Rath merged 1 commit into
google:mainfrom
ackama:always-use-unique-path

Conversation

@G-Rath
Copy link
Copy Markdown
Collaborator

@G-Rath G-Rath commented Jan 8, 2026

Since #2445 has us stream bytes to and from disk rather than writing the entire contents in one go, it's no longer safe for tests to be using the databases in parallel so we always need to use a unique directory

@G-Rath G-Rath force-pushed the always-use-unique-path branch from 962b262 to 19a7f0d Compare January 9, 2026 00:54
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.79%. Comparing base (b806e83) to head (19a7f0d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2451   +/-   ##
=======================================
  Coverage   67.79%   67.79%           
=======================================
  Files         172      172           
  Lines       13301    13301           
=======================================
  Hits         9018     9018           
  Misses       3573     3573           
  Partials      710      710           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@G-Rath G-Rath enabled auto-merge (squash) January 9, 2026 01:15
@G-Rath G-Rath merged commit d44e578 into google:main Jan 9, 2026
44 of 47 checks passed
@G-Rath G-Rath deleted the always-use-unique-path branch January 9, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants