fix: fix MIME type error in UploadFromPath and add unit tests. fixes: #247

PiperOrigin-RevId: 748331799

Author: qiaodev

api_client.go

@@ -270,7 +270,8 @@ func newAPIError(resp *http.Response) error {
 
 	if len(body) > 0 {
 		if err := json.Unmarshal(body, respWithError); err != nil {
-			return fmt.Errorf("newAPIError: unmarshal response to error failed: %w. Response: %v", err, string(body))
+			// Handle plain text error message. File upload backend doesn't return json error message.
+			return APIError{Code: resp.StatusCode, Status: resp.Status, Message: string(body)}
 		}
 		return *respWithError.ErrorInfo
 	}
@@ -380,7 +381,8 @@ func (ac *apiClient) uploadFile(ctx context.Context, r io.Reader, uploadURL stri
 		offset += int64(bytesRead)
 
 		uploadStatus := resp.Header.Get("X-Goog-Upload-Status")
-		if uploadStatus != "final" && strings.Contains(uploadStatus, "finalize") {
+
+		if uploadStatus != "final" && strings.Contains(uploadCommand, "finalize") {
 			return nil, fmt.Errorf("send finalize command but doesn't receive final status. Offset %d, Bytes read: %d, Upload status: %s", offset, bytesRead, uploadStatus)
 		}
 		if uploadStatus != "active" {

api_client_test.go

@@ -321,7 +321,7 @@ func TestSendStreamRequest(t *testing.T) {
 			mockResponse:     `invalid json`,
 			mockStatusCode:   http.StatusBadRequest,
 			wantErr:          true,
-			wantErrorMessage: "newAPIError: unmarshal response to error failed: invalid character 'i' looking for beginning of value. Response: invalid json",
+			wantErrorMessage: "Error 400, Message: invalid json, Status: 400 Bad Request, Details: []",
 		},
 		{
 			name:             "Error Response with server error",
@@ -351,7 +351,7 @@ func TestSendStreamRequest(t *testing.T) {
 			mockResponse:     `invalid json`,
 			mockStatusCode:   http.StatusInternalServerError,
 			wantErr:          true,
-			wantErrorMessage: "newAPIError: unmarshal response to error failed: invalid character 'i' looking for beginning of value. Response: invalid json",
+			wantErrorMessage: "Error 500, Message: invalid json, Status: 500 Internal Server Error, Details: []",
 		},
 		{
 			name:           "Request Error",