Skip to content

Commit 1026dc7

Browse files
authored
test(pubsub): remove t.Parallel from exactly once deadline exceeded tests (#7217)
1 parent 96cda24 commit 1026dc7

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

pubsub/subscription_test.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -586,7 +586,6 @@ func TestExactlyOnceDelivery_AckFailureErrorPermissionDenied(t *testing.T) {
586586
}
587587

588588
func TestExactlyOnceDelivery_AckRetryDeadlineExceeded(t *testing.T) {
589-
t.Parallel()
590589
ctx, cancel := context.WithCancel(context.Background())
591590
srv := pstest.NewServer(pstest.WithErrorInjection("Acknowledge", codes.Internal, "internal error"))
592591
client, err := NewClient(ctx, projName,
@@ -621,7 +620,7 @@ func TestExactlyOnceDelivery_AckRetryDeadlineExceeded(t *testing.T) {
621620
MinExtensionPeriod: 2 * time.Minute,
622621
}
623622
// Override the default timeout here so this test doesn't take 10 minutes.
624-
exactlyOnceDeliveryRetryDeadline = 1 * time.Minute
623+
exactlyOnceDeliveryRetryDeadline = 20 * time.Second
625624
err = s.Receive(ctx, func(ctx context.Context, msg *Message) {
626625
ar := msg.AckWithResult()
627626
s, err := ar.Get(ctx)
@@ -682,7 +681,6 @@ func TestExactlyOnceDelivery_NackSuccess(t *testing.T) {
682681
}
683682

684683
func TestExactlyOnceDelivery_NackRetry_DeadlineExceeded(t *testing.T) {
685-
t.Parallel()
686684
ctx, cancel := context.WithCancel(context.Background())
687685
srv := pstest.NewServer(pstest.WithErrorInjection("ModifyAckDeadline", codes.Internal, "internal error"))
688686
client, err := NewClient(ctx, projName,
@@ -718,7 +716,7 @@ func TestExactlyOnceDelivery_NackRetry_DeadlineExceeded(t *testing.T) {
718716
MaxExtensionPeriod: 2 * time.Minute,
719717
}
720718
// Override the default timeout here so this test doesn't take 10 minutes.
721-
exactlyOnceDeliveryRetryDeadline = 1 * time.Minute
719+
exactlyOnceDeliveryRetryDeadline = 20 * time.Second
722720
var once sync.Once
723721
err = s.Receive(ctx, func(ctx context.Context, msg *Message) {
724722
once.Do(func() {

0 commit comments

Comments
 (0)