chore: prober/multihttp: test with all k6 binaries found in dist

Author: nadiamoe

internal/prober/multihttp/script_test.go

@@ -5,6 +5,7 @@ import (
 	"context"
 	"net/http"
 	"net/http/httptest"
+	"path/filepath"
 	"strings"
 	"testing"
 
@@ -846,31 +847,34 @@ func TestSettingsToScript(t *testing.T) {
 		},
 	}
 
-	ctx, cancel := testhelper.Context(context.Background(), t)
-	t.Cleanup(cancel)
+	for _, k6path := range testhelper.K6Paths(t) {
+		t.Run(filepath.Base(k6path), func(t *testing.T) {
+			ctx, cancel := testhelper.Context(context.Background(), t)
+			t.Cleanup(cancel)
 
-	k6path := testhelper.K6Path(t)
-	store := testhelper.NoopSecretStore{}
-	runner, err := k6runner.New(k6runner.RunnerOpts{Uri: k6path})
-	require.NoError(t, err)
+			store := testhelper.NoopSecretStore{}
+			runner, err := k6runner.New(k6runner.RunnerOpts{Uri: k6path})
+			require.NoError(t, err)
 
-	logger := testhelper.Logger(t)
-	prober, err := NewProber(ctx, check, logger, runner, http.Header{}, &store)
-	require.NoError(t, err)
+			logger := testhelper.Logger(t)
+			prober, err := NewProber(ctx, check, logger, runner, http.Header{}, &store)
+			require.NoError(t, err)
 
-	reg := prometheus.NewPedanticRegistry()
-	require.NotNil(t, reg)
+			reg := prometheus.NewPedanticRegistry()
+			require.NotNil(t, reg)
 
-	var buf bytes.Buffer
-	userLogger := level.NewFilter(kitlog.NewLogfmtLogger(&buf), level.AllowInfo(), level.SquelchNoLevel(false))
-	require.NotNil(t, userLogger)
+			var buf bytes.Buffer
+			userLogger := level.NewFilter(kitlog.NewLogfmtLogger(&buf), level.AllowInfo(), level.SquelchNoLevel(false))
+			require.NotNil(t, userLogger)
 
-	success, duration := prober.Probe(ctx, check.Target, reg, userLogger)
+			success, duration := prober.Probe(ctx, check.Target, reg, userLogger)
 
-	t.Log("Log entries:\n" + buf.String())
+			t.Log("Log entries:\n" + buf.String())
 
-	require.True(t, success)
-	require.NotEqual(t, 0, duration)
+			require.True(t, success)
+			require.NotEqual(t, 0, duration)
+		})
+	}
 }
 
 func TestReplaceVariablesInString(t *testing.T) {

internal/testhelper/testhelper.go

@@ -7,6 +7,7 @@ import (
 	"os"
 	"path/filepath"
 	"runtime"
+	"strings"
 	"testing"
 	"time"
 
@@ -76,13 +77,28 @@ func ModuleDir(t *testing.T) string {
 	return dir
 }
 
-func K6Path(t *testing.T) string {
+func K6Paths(t *testing.T) []string {
 	t.Helper()
 
-	k6path := filepath.Join(ModuleDir(t), "dist", runtime.GOOS+"-"+runtime.GOARCH, "sm-k6")
-	require.FileExistsf(t, k6path, "k6 program must exist at %s", k6path)
+	dir := filepath.Join(ModuleDir(t), "dist", runtime.GOOS+"-"+runtime.GOARCH)
+	entries, err := os.ReadDir(dir)
+	require.NoErrorf(t, err, "reading k6 binaries directory %s", dir)
 
-	return k6path
+	var paths []string
+	for _, entry := range entries {
+		if entry.IsDir() || !strings.Contains(entry.Name(), "k6") {
+			continue
+		}
+		info, err := entry.Info()
+		if err != nil || info.Mode().Perm()&0o111 == 0 {
+			continue
+		}
+		paths = append(paths, filepath.Join(dir, entry.Name()))
+	}
+
+	require.NotEmptyf(t, paths, "no k6 binaries found in %s", dir)
+
+	return paths
 }
 
 // NoopSecretStore is a test implementation of the SecretProvider interface