Skip to content

Remove tempo serverless#4599

Merged
electron0zero merged 11 commits intografana:mainfrom
electron0zero:serverless
Jan 24, 2025
Merged

Remove tempo serverless#4599
electron0zero merged 11 commits intografana:mainfrom
electron0zero:serverless

Conversation

@electron0zero
Copy link
Copy Markdown
Member

@electron0zero electron0zero commented Jan 23, 2025

What this PR does:
serverless was deprecated in tempo 2.7 release.

Tempo serverless related code, config options, and docs is being removed.

This PR Removes:

  1. serverless config options from the tempo config
    2.serverless doc pages and mention from the docs
  2. serverless dashboard panels from tempo-mixin, and removes mention of serverless from playbook

following config options are no longer valid:

querier:
    search:
        prefer_self: <int>
        external_hedge_requests_at: <duration>
        external_hedge_requests_up_to:  <duration>
        external_backend: <string>
        google_cloud_run: <string>
        external_endpoints: <array>

following serverless related metrics are being removed:

tempo_querier_external_endpoint_duration_seconds
tempo_querier_external_endpoint_hedged_roundtrips_total
tempo_feature_enabled

Which issue(s) this PR fixes:
Fixes #4014

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@electron0zero electron0zero changed the title remove tempo-serverless from cmd Remove tempo serverless Jan 23, 2025
Copy link
Copy Markdown
Contributor

@mdisibio mdisibio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Good bye serverless. Nice cleanup

Comment thread CHANGELOG.md
Comment thread cmd/tempo/app/app.go Outdated
Comment thread docs/sources/tempo/operations/serverless_aws.md
Comment thread modules/querier/querier.go Outdated
Copy link
Copy Markdown
Collaborator

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o7 serverless

I'm good on this as well. Let's just wait for Kim to weigh in on removing the docs pages and then we can merge.

Copy link
Copy Markdown
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the doc! Changes look good! We should add an alias for any deleted pages. For an example of an alias: #4598 (comment)

Note that aliases use relative locations. For detailed instructions: https://grafana.com/docs/writers-toolkit/write/front-matter/#aliases

@electron0zero electron0zero enabled auto-merge (squash) January 24, 2025 04:46
@electron0zero electron0zero merged commit 51aca06 into grafana:main Jan 24, 2025
@electron0zero electron0zero deleted the serverless branch January 24, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove support for serverless functions

4 participants