fix possible nil before casting (#5017)

charlesxsh · web-flow · commit 46935b96506d · 2021-12-01T15:10:13.000-08:00
diff --git a/xds/internal/balancer/clustermanager/clustermanager_test.go b/xds/internal/balancer/clustermanager/clustermanager_test.go
@@ -559,9 +559,12 @@ func TestClusterManagerForwardsBalancerBuildOptions(t *testing.T) {
 	}
 	ctx, cancel := context.WithTimeout(context.Background(), defaultTestTimeout)
 	defer cancel()
-	if v, err := ccsCh.Receive(ctx); err != nil {
-		err2 := v.(error)
-		t.Fatal(err2)
+	v, err := ccsCh.Receive(ctx)
+	if err != nil {
+		t.Fatalf("timed out waiting for UpdateClientConnState result: %v", err)
+	}
+	if v != nil {
+		t.Fatal(v)
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -559,9 +559,12 @@ func TestClusterManagerForwardsBalancerBuildOptions(t *testing.T) {`
`559`	`559`	`}`
`560`	`560`	`ctx, cancel := context.WithTimeout(context.Background(), defaultTestTimeout)`
`561`	`561`	`defer cancel()`
`562`		`- if v, err := ccsCh.Receive(ctx); err != nil {`
`563`		`- err2 := v.(error)`
`564`		`- t.Fatal(err2)`
	`562`	`+ v, err := ccsCh.Receive(ctx)`
	`563`	`+ if err != nil {`
	`564`	`+ t.Fatalf("timed out waiting for UpdateClientConnState result: %v", err)`
	`565`	`+ }`
	`566`	`+ if v != nil {`
	`567`	`+ t.Fatal(v)`
`565`	`568`	`}`
`566`	`569`	`}`
`567`	`570`