Skip to content

feat: add attribute create_time to data source #41839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stefanfreitag
Copy link
Contributor

Description

Add the attribute create_time to data source aws_ebs_volume

Relations

Closes #41796

References

Output from Acceptance Testing

make testacc TESTS=TestAccEC2EBSVolumeDataSource_basic PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.7 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2EBSVolumeDataSource_basic'  -timeout 360m -vet=off
2025/03/13 20:12:44 Initializing Terraform AWS Provider...
=== RUN   TestAccEC2EBSVolumeDataSource_basic
=== PAUSE TestAccEC2EBSVolumeDataSource_basic
=== CONT  TestAccEC2EBSVolumeDataSource_basic
--- PASS: TestAccEC2EBSVolumeDataSource_basic (48.12s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        48.336s
...

Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. size/XS Managed by automation to categorize the size of a PR. labels Mar 13, 2025
@stefanfreitag stefanfreitag marked this pull request as ready for review March 13, 2025 20:13
@stefanfreitag stefanfreitag requested a review from a team as a code owner March 13, 2025 20:13
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 13, 2025
jar-b
jar-b previously approved these changes Mar 14, 2025
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=ebs TESTS="TestAccEC2EBSVolumeDataSource_|TestAccEC2EBSVolume_"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.7 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2EBSVolumeDataSource_|TestAccEC2EBSVolume_'  -timeout 360m -vet=off
2025/03/14 09:37:30 Initializing Terraform AWS Provider...

=== NAME  TestAccEC2EBSVolume_outpost
    ebs_volume_test.go:502: skipping since no Outposts found
--- SKIP: TestAccEC2EBSVolume_outpost (0.85s)
=== CONT  TestAccEC2EBSVolume_multiAttach_io1
--- PASS: TestAccEC2EBSVolume_multiAttach_gp2 (4.94s)
=== CONT  TestAccEC2EBSVolumeDataSource_multipleFilters
--- PASS: TestAccEC2EBSVolume_disappears (50.02s)
=== CONT  TestAccEC2EBSVolume_UpdateIops_io2
--- PASS: TestAccEC2EBSVolumeDataSource_basic (51.12s)
=== CONT  TestAccEC2EBSVolume_gp3ToGP2
--- PASS: TestAccEC2EBSVolumeDataSource_multipleFilters (46.33s)
=== CONT  TestAccEC2EBSVolume_invalidThroughputForType
--- PASS: TestAccEC2EBSVolume_invalidThroughputForType (1.77s)
=== CONT  TestAccEC2EBSVolume_invalidIopsForType
--- PASS: TestAccEC2EBSVolume_invalidIopsForType (1.71s)
--- PASS: TestAccEC2EBSVolume_GP3_basic (58.23s)
--- PASS: TestAccEC2EBSVolume_multiAttach_io1 (57.51s)
--- PASS: TestAccEC2EBSVolume_basic (58.65s)
--- PASS: TestAccEC2EBSVolume_multiAttach_io2 (58.91s)
--- PASS: TestAccEC2EBSVolume_noIops (58.92s)
--- PASS: TestAccEC2EBSVolume_kmsKey (60.95s)
--- PASS: TestAccEC2EBSVolume_withTags (80.12s)
--- PASS: TestAccEC2EBSVolume_GP3_iops (81.29s)
--- PASS: TestAccEC2EBSVolume_updateSize (81.96s)
--- PASS: TestAccEC2EBSVolume_UpdateIops_io1 (82.05s)
--- PASS: TestAccEC2EBSVolume_io1ToGP3 (82.08s)
--- PASS: TestAccEC2EBSVolume_updateType (82.08s)
--- PASS: TestAccEC2EBSVolume_GP3_throughput (82.35s)
--- PASS: TestAccEC2EBSVolume_snapshotIDAndSize (106.84s)
--- PASS: TestAccEC2EBSVolume_UpdateIops_io2 (57.34s)
--- PASS: TestAccEC2EBSVolume_gp3ToGP2 (56.90s)
--- PASS: TestAccEC2EBSVolume_finalSnapshot (112.29s)
--- PASS: TestAccEC2EBSVolume_snapshotID (135.06s)
--- PASS: TestAccEC2EBSVolume_updateAttachedEBSVolume (142.26s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        149.342s

@jar-b
Copy link
Member

jar-b commented Mar 14, 2025

Thanks for your contribution, @stefanfreitag! 👍

I added this attribute to the aws_ebs_volume resource as well for completeness.

Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jar-b jar-b merged commit a2b4dd3 into hashicorp:main Mar 14, 2025
43 checks passed
Copy link

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.92.0 milestone Mar 14, 2025
@stefanfreitag stefanfreitag deleted the f-aws_ebs_volume-add-create-at-attribute branch March 17, 2025 13:04
Copy link

This functionality has been released in v5.92.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_ebs_volume should return CreateTime
4 participants