Skip to content

r/aws_timestreaminfluxdb_db_instance: Set new computed value for ondary_availability_zone attribute when changing deployment_type #41849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Mar 14, 2025

Description

Found while running acceptance tests for #40661:

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccTimestreamInfluxDBDBInstance_' PKG=timestreaminfluxdb ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.7 test ./internal/service/timestreaminfluxdb/... -v -count 1 -parallel 2  -run=TestAccTimestreamInfluxDBDBInstance_ -timeout 720m -vet=off
2025/03/13 08:25:54 Initializing Terraform AWS Provider...
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_null
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_null
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_EmptyMap
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_EmptyMap
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_AddOnUpdate
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_AddOnUpdate
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnCreate
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnCreate
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_providerOnly
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_providerOnly
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nonOverlapping
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_overlapping
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_overlapping
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnCreate
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnCreate
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccTimestreamInfluxDBDBInstance_basic
=== PAUSE TestAccTimestreamInfluxDBDBInstance_basic
=== RUN   TestAccTimestreamInfluxDBDBInstance_disappears
=== PAUSE TestAccTimestreamInfluxDBDBInstance_disappears
=== RUN   TestAccTimestreamInfluxDBDBInstance_dbInstanceType
=== PAUSE TestAccTimestreamInfluxDBDBInstance_dbInstanceType
=== RUN   TestAccTimestreamInfluxDBDBInstance_logDeliveryConfiguration
=== PAUSE TestAccTimestreamInfluxDBDBInstance_logDeliveryConfiguration
=== RUN   TestAccTimestreamInfluxDBDBInstance_networkType
=== PAUSE TestAccTimestreamInfluxDBDBInstance_networkType
=== RUN   TestAccTimestreamInfluxDBDBInstance_port
=== PAUSE TestAccTimestreamInfluxDBDBInstance_port
=== RUN   TestAccTimestreamInfluxDBDBInstance_allocatedStorage
=== PAUSE TestAccTimestreamInfluxDBDBInstance_allocatedStorage
=== RUN   TestAccTimestreamInfluxDBDBInstance_dbStorageType
=== PAUSE TestAccTimestreamInfluxDBDBInstance_dbStorageType
=== RUN   TestAccTimestreamInfluxDBDBInstance_publiclyAccessible
=== PAUSE TestAccTimestreamInfluxDBDBInstance_publiclyAccessible
=== RUN   TestAccTimestreamInfluxDBDBInstance_deploymentType
=== PAUSE TestAccTimestreamInfluxDBDBInstance_deploymentType
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnCreate
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags (1137.72s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nonOverlapping
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnCreate (1499.83s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nullNonOverlappingResourceTag (298.11s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nullOverlappingResourceTag (510.94s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nonOverlapping (2245.57s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_emptyProviderOnlyTag (1892.10s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_emptyResourceTag (1472.93s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_updateToResourceOnly (1525.86s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_overlapping
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_updateToProviderOnly (1831.98s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_logDeliveryConfiguration
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_overlapping (1826.85s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_deploymentType
--- PASS: TestAccTimestreamInfluxDBDBInstance_logDeliveryConfiguration (2034.34s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_publiclyAccessible
=== NAME  TestAccTimestreamInfluxDBDBInstance_deploymentType
    db_instance_test.go:455: Step 3/4 error: Error running apply: exit status 1
        
        Error: Provider produced inconsistent result after apply
        
        When applying changes to aws_timestreaminfluxdb_db_instance.test, provider
        "provider[\"registry.terraform.io/hashicorp/aws\"]" produced an unexpected
        new value: .secondary_availability_zone: was cty.StringVal("us-west-2b"), but
        now cty.StringVal("").
        
        This is a bug in the provider, which should be reported in the provider's own
        issue tracker.
--- FAIL: TestAccTimestreamInfluxDBDBInstance_deploymentType (2598.40s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_dbStorageType
--- PASS: TestAccTimestreamInfluxDBDBInstance_publiclyAccessible (1468.54s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_allocatedStorage
--- PASS: TestAccTimestreamInfluxDBDBInstance_dbStorageType (1506.05s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_port
--- PASS: TestAccTimestreamInfluxDBDBInstance_allocatedStorage (2021.22s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_networkType
--- PASS: TestAccTimestreamInfluxDBDBInstance_port (1129.93s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnCreate
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnCreate (1278.75s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_providerOnly
--- PASS: TestAccTimestreamInfluxDBDBInstance_networkType (2634.66s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_providerOnly (1710.98s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnUpdate_Replace (1617.05s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnUpdate_Add (1560.45s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_dbInstanceType
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_IgnoreTags_Overlap_ResourceTag (1570.30s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_disappears
--- PASS: TestAccTimestreamInfluxDBDBInstance_dbInstanceType (2033.85s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_basic
--- PASS: TestAccTimestreamInfluxDBDBInstance_disappears (1570.59s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_EmptyMap
--- PASS: TestAccTimestreamInfluxDBDBInstance_basic (845.90s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_AddOnUpdate
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_EmptyMap (1029.74s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_null
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_AddOnUpdate (1102.99s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_null (1237.46s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnUpdate_Replace (1385.32s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_IgnoreTags_Overlap_DefaultTag (1825.35s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnUpdate_Add (1254.66s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/timestreaminfluxdb	23966.758s
FAIL
make: *** [testacc] Error 1

Output from Acceptance Testing

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccTimestreamInfluxDBDBInstance_deploymentType\|TestAccTimestreamInfluxDBDBInstance_dbStorageType' PKG=timestreaminfluxdb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.7 test ./internal/service/timestreaminfluxdb/... -v -count 1 -parallel 20  -run=TestAccTimestreamInfluxDBDBInstance_deploymentType\|TestAccTimestreamInfluxDBDBInstance_dbStorageType -timeout 720m -vet=off
2025/03/14 10:08:59 Initializing Terraform AWS Provider...
=== RUN   TestAccTimestreamInfluxDBDBInstance_dbStorageType
=== PAUSE TestAccTimestreamInfluxDBDBInstance_dbStorageType
=== RUN   TestAccTimestreamInfluxDBDBInstance_deploymentType
=== PAUSE TestAccTimestreamInfluxDBDBInstance_deploymentType
=== CONT  TestAccTimestreamInfluxDBDBInstance_dbStorageType
=== CONT  TestAccTimestreamInfluxDBDBInstance_deploymentType
--- PASS: TestAccTimestreamInfluxDBDBInstance_deploymentType (1245.40s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_dbStorageType (2061.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/timestreaminfluxdb	2067.262s

…ondary_availability_zone` attribute when changing `deployment_type.
@ewbankkit ewbankkit requested a review from a team as a code owner March 14, 2025 12:41
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/timestreaminfluxdb Issues and PRs that pertain to the timestreaminfluxdb service. size/XS Managed by automation to categorize the size of a PR. labels Mar 14, 2025
johnsonaj
johnsonaj previously approved these changes Mar 14, 2025
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions github-actions bot added sweeper Pertains to changes to or issues with the sweeper. size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Mar 14, 2025
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS="-run=TestAccTimestreamInfluxDBDBInstance_deploymentType" PKG=timestreaminfluxdb

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.7 test ./internal/service/timestreaminfluxdb/... -v -count 1 -parallel 20  -run=TestAccTimestreamInfluxDBDBInstance_deploymentType -timeout 360m -vet=off
2025/03/14 10:08:42 Initializing Terraform AWS Provider...
=== RUN   TestAccTimestreamInfluxDBDBInstance_deploymentType
=== PAUSE TestAccTimestreamInfluxDBDBInstance_deploymentType
=== CONT  TestAccTimestreamInfluxDBDBInstance_deploymentType
--- PASS: TestAccTimestreamInfluxDBDBInstance_deploymentType (1346.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/timestreaminfluxdb	1353.642s

@ewbankkit ewbankkit merged commit 84ae10f into main Mar 14, 2025
38 checks passed
@ewbankkit ewbankkit deleted the b-aws_timestreaminfluxdb_db_instance.secondary_availability_zone-NewComputed branch March 14, 2025 15:40
Copy link

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.92.0 milestone Mar 14, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Mar 14, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 20, 2025
Copy link

This functionality has been released in v5.92.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/timestreaminfluxdb Issues and PRs that pertain to the timestreaminfluxdb service. size/S Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants