Skip to content

f/verified access update resources with new fields #41957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Mar 26, 2025
Merged

f/verified access update resources with new fields #41957

merged 32 commits into from
Mar 26, 2025

Conversation

esteban1983cl
Copy link

@esteban1983cl esteban1983cl commented Mar 22, 2025 •
edited by ewbankkit
Loading

Description

This update aws_verified_access resources due new fields introduced from AWS SDK for Go V2 and Verified Access new functionalities from AWS Cloud.

Relations

N/A

References

Closes #41976.
Closes #41972.

Output from Acceptance Testing

❯ make testacc P=5 TESTS=TestAccVerifiedAccess PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.7 test ./internal/service/ec2/... -v -count 1 -parallel 5 -run='TestAccVerifiedAccess'  -timeout 360m -vet=off
2025/03/21 20:35:10 Initializing Terraform AWS Provider...
=== RUN   TestAccVerifiedAccess_serial
=== PAUSE TestAccVerifiedAccess_serial
=== RUN   TestAccVerifiedAccessTrustProvider_basic
=== PAUSE TestAccVerifiedAccessTrustProvider_basic
=== RUN   TestAccVerifiedAccessTrustProvider_deviceOptions
=== PAUSE TestAccVerifiedAccessTrustProvider_deviceOptions
=== RUN   TestAccVerifiedAccessTrustProvider_disappears
=== PAUSE TestAccVerifiedAccessTrustProvider_disappears
=== RUN   TestAccVerifiedAccessTrustProvider_oidcOptions
=== PAUSE TestAccVerifiedAccessTrustProvider_oidcOptions
=== RUN   TestAccVerifiedAccessTrustProvider_tags
=== PAUSE TestAccVerifiedAccessTrustProvider_tags
=== CONT  TestAccVerifiedAccess_serial
=== RUN   TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic
=== CONT  TestAccVerifiedAccessTrustProvider_disappears
=== PAUSE TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic
=== CONT  TestAccVerifiedAccessTrustProvider_deviceOptions
=== CONT  TestAccVerifiedAccessTrustProvider_basic
=== CONT  TestAccVerifiedAccessTrustProvider_tags
=== RUN   TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears
=== PAUSE TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears
=== RUN   TestAccVerifiedAccess_serial/Endpoint_disappears
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_disappears
=== RUN   TestAccVerifiedAccess_serial/Endpoint_policyDocument
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_policyDocument
=== RUN   TestAccVerifiedAccess_serial/Endpoint_subnetIDs
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_subnetIDs
=== RUN   TestAccVerifiedAccess_serial/Endpoint_cidr
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_cidr
=== RUN   TestAccVerifiedAccess_serial/Endpoint_rds
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_rds
=== RUN   TestAccVerifiedAccess_serial/Endpoint_basic
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_basic
=== RUN   TestAccVerifiedAccess_serial/Endpoint_networkInterface
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_networkInterface
=== RUN   TestAccVerifiedAccess_serial/Endpoint_tags
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_tags
=== RUN   TestAccVerifiedAccess_serial/Group_policy
=== PAUSE TestAccVerifiedAccess_serial/Group_policy
=== RUN   TestAccVerifiedAccess_serial/Group_updatePolicy
=== PAUSE TestAccVerifiedAccess_serial/Group_updatePolicy
=== RUN   TestAccVerifiedAccess_serial/Group_setPolicy
=== PAUSE TestAccVerifiedAccess_serial/Group_setPolicy
=== RUN   TestAccVerifiedAccess_serial/Group_basic
=== PAUSE TestAccVerifiedAccess_serial/Group_basic
=== RUN   TestAccVerifiedAccess_serial/Group_kms
=== PAUSE TestAccVerifiedAccess_serial/Group_kms
=== RUN   TestAccVerifiedAccess_serial/Group_updateKMS
=== PAUSE TestAccVerifiedAccess_serial/Group_updateKMS
=== RUN   TestAccVerifiedAccess_serial/Group_disappears
=== PAUSE TestAccVerifiedAccess_serial/Group_disappears
=== RUN   TestAccVerifiedAccess_serial/Group_tags
=== PAUSE TestAccVerifiedAccess_serial/Group_tags
=== RUN   TestAccVerifiedAccess_serial/Instance_fipsEnabled
=== PAUSE TestAccVerifiedAccess_serial/Instance_fipsEnabled
=== RUN   TestAccVerifiedAccess_serial/Instance_disappears
=== PAUSE TestAccVerifiedAccess_serial/Instance_disappears
=== RUN   TestAccVerifiedAccess_serial/Instance_tags
=== PAUSE TestAccVerifiedAccess_serial/Instance_tags
=== RUN   TestAccVerifiedAccess_serial/Instance_cidrEndpointsCustomSubDomain
=== PAUSE TestAccVerifiedAccess_serial/Instance_cidrEndpointsCustomSubDomain
=== RUN   TestAccVerifiedAccess_serial/Instance_basic
=== PAUSE TestAccVerifiedAccess_serial/Instance_basic
=== RUN   TestAccVerifiedAccess_serial/Instance_description
=== PAUSE TestAccVerifiedAccess_serial/Instance_description
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion
=== CONT  TestAccVerifiedAccessTrustProvider_oidcOptions
--- PASS: TestAccVerifiedAccessTrustProvider_disappears (48.85s)
=== CONT  TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic
--- PASS: TestAccVerifiedAccessTrustProvider_deviceOptions (52.18s)
=== CONT  TestAccVerifiedAccess_serial/Group_disappears
--- PASS: TestAccVerifiedAccessTrustProvider_oidcOptions (51.53s)
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion
--- PASS: TestAccVerifiedAccessTrustProvider_basic (53.19s)
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3
--- PASS: TestAccVerifiedAccessTrustProvider_tags (76.30s)
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs
=== CONT  TestAccVerifiedAccess_serial/Instance_description
=== CONT  TestAccVerifiedAccess_serial/Instance_basic
=== CONT  TestAccVerifiedAccess_serial/Instance_cidrEndpointsCustomSubDomain
=== CONT  TestAccVerifiedAccess_serial/Instance_tags
=== CONT  TestAccVerifiedAccess_serial/Instance_disappears
=== CONT  TestAccVerifiedAccess_serial/Instance_fipsEnabled
=== CONT  TestAccVerifiedAccess_serial/Group_tags
=== CONT  TestAccVerifiedAccess_serial/Endpoint_networkInterface
=== CONT  TestAccVerifiedAccess_serial/Group_updateKMS
=== CONT  TestAccVerifiedAccess_serial/Group_kms
=== CONT  TestAccVerifiedAccess_serial/Group_basic
=== CONT  TestAccVerifiedAccess_serial/Group_setPolicy
=== CONT  TestAccVerifiedAccess_serial/Group_updatePolicy
=== CONT  TestAccVerifiedAccess_serial/Group_policy
=== CONT  TestAccVerifiedAccess_serial/Endpoint_tags
=== CONT  TestAccVerifiedAccess_serial/Endpoint_subnetIDs
=== CONT  TestAccVerifiedAccess_serial/Endpoint_basic
=== CONT  TestAccVerifiedAccess_serial/Endpoint_rds
=== CONT  TestAccVerifiedAccess_serial/Endpoint_disappears
=== CONT  TestAccVerifiedAccess_serial/Endpoint_policyDocument
=== CONT  TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears
=== CONT  TestAccVerifiedAccess_serial/Endpoint_cidr
--- PASS: TestAccVerifiedAccess_serial (1.64s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic (21.82s)
    --- PASS: TestAccVerifiedAccess_serial/Group_disappears (22.06s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext (35.83s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion (36.05s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears (19.45s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3 (42.61s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_description (30.27s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs (34.66s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_basic (19.41s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_cidrEndpointsCustomSubDomain (19.72s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_disappears (16.79s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_tags (42.53s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_fipsEnabled (31.57s)
    --- PASS: TestAccVerifiedAccess_serial/Group_tags (52.20s)
    --- PASS: TestAccVerifiedAccess_serial/Group_updateKMS (44.27s)
    --- PASS: TestAccVerifiedAccess_serial/Group_kms (25.36s)
    --- PASS: TestAccVerifiedAccess_serial/Group_basic (24.35s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose (163.05s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3 (181.49s)
    --- PASS: TestAccVerifiedAccess_serial/Group_setPolicy (43.24s)
    --- PASS: TestAccVerifiedAccess_serial/Group_policy (24.79s)
    --- PASS: TestAccVerifiedAccess_serial/Group_updatePolicy (42.78s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_networkInterface (1298.18s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_tags (1383.34s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_basic (1548.12s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears (19.42s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_rds (2318.41s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_policyDocument (1251.25s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_subnetIDs (2648.73s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_disappears (1608.15s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_cidr (1950.82s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        3802.056s

...

Dolape1983 added 10 commits March 18, 2025 11:46
@esteban1983cl esteban1983cl requested a review from a team as a code owner March 22, 2025 02:59
@github-actions GitHub Actions
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. linter Pertains to changes to or issues with the various linters. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. size/XL Managed by automation to categorize the size of a PR. labels Mar 22, 2025
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 24, 2025
ewbankkit
ewbankkit reviewed Mar 25, 2025
View reviewed changes
@ewbankkit ewbankkit added the waiting-response Maintainers are waiting on response from community or contributor. label Mar 25, 2025
@ewbankkit ewbankkit removed the waiting-response Maintainers are waiting on response from community or contributor. label Mar 26, 2025
@ewbankkit ewbankkit self-assigned this Mar 26, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 26, 2025
ewbankkit added 10 commits March 26, 2025 10:23
@ewbankkit
Acceptance test output:
dfe4f1b 
% make testacc TESTARGS='-run=TestAccVerifiedAccess_serial' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.7 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVerifiedAccess_serial -timeout 360m -vet=off
2025/03/26 08:53:43 Initializing Terraform AWS Provider...
=== RUN   TestAccVerifiedAccess_serial
=== PAUSE TestAccVerifiedAccess_serial
=== CONT  TestAccVerifiedAccess_serial
=== RUN   TestAccVerifiedAccess_serial/Endpoint_basic
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_basic
=== RUN   TestAccVerifiedAccess_serial/Endpoint_networkInterface
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_networkInterface
=== RUN   TestAccVerifiedAccess_serial/Endpoint_tags
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_tags
=== RUN   TestAccVerifiedAccess_serial/Endpoint_disappears
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_disappears
=== RUN   TestAccVerifiedAccess_serial/Endpoint_policyDocument
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_policyDocument
=== RUN   TestAccVerifiedAccess_serial/Endpoint_subnetIDs
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_subnetIDs
=== RUN   TestAccVerifiedAccess_serial/Endpoint_cidr
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_cidr
=== RUN   TestAccVerifiedAccess_serial/Endpoint_rds
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_rds
=== RUN   TestAccVerifiedAccess_serial/Group_setPolicy
=== PAUSE TestAccVerifiedAccess_serial/Group_setPolicy
=== RUN   TestAccVerifiedAccess_serial/Group_basic
=== PAUSE TestAccVerifiedAccess_serial/Group_basic
=== RUN   TestAccVerifiedAccess_serial/Group_kms
=== PAUSE TestAccVerifiedAccess_serial/Group_kms
=== RUN   TestAccVerifiedAccess_serial/Group_updateKMS
=== PAUSE TestAccVerifiedAccess_serial/Group_updateKMS
=== RUN   TestAccVerifiedAccess_serial/Group_disappears
=== PAUSE TestAccVerifiedAccess_serial/Group_disappears
=== RUN   TestAccVerifiedAccess_serial/Group_tags
=== PAUSE TestAccVerifiedAccess_serial/Group_tags
=== RUN   TestAccVerifiedAccess_serial/Group_policy
=== PAUSE TestAccVerifiedAccess_serial/Group_policy
=== RUN   TestAccVerifiedAccess_serial/Group_updatePolicy
=== PAUSE TestAccVerifiedAccess_serial/Group_updatePolicy
=== RUN   TestAccVerifiedAccess_serial/Instance_basic
=== PAUSE TestAccVerifiedAccess_serial/Instance_basic
=== RUN   TestAccVerifiedAccess_serial/Instance_description
=== PAUSE TestAccVerifiedAccess_serial/Instance_description
=== RUN   TestAccVerifiedAccess_serial/Instance_fipsEnabled
=== PAUSE TestAccVerifiedAccess_serial/Instance_fipsEnabled
=== RUN   TestAccVerifiedAccess_serial/Instance_disappears
=== PAUSE TestAccVerifiedAccess_serial/Instance_disappears
=== RUN   TestAccVerifiedAccess_serial/Instance_tags
=== PAUSE TestAccVerifiedAccess_serial/Instance_tags
=== RUN   TestAccVerifiedAccess_serial/Instance_cidrEndpointsCustomSubDomain
=== PAUSE TestAccVerifiedAccess_serial/Instance_cidrEndpointsCustomSubDomain
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3
=== RUN   TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic
=== PAUSE TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic
=== RUN   TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears
=== PAUSE TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears
=== CONT  TestAccVerifiedAccess_serial/Endpoint_basic
=== CONT  TestAccVerifiedAccess_serial/Instance_basic
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3
=== CONT  TestAccVerifiedAccess_serial/Instance_tags
=== CONT  TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears
=== CONT  TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose
=== CONT  TestAccVerifiedAccess_serial/Instance_cidrEndpointsCustomSubDomain
=== CONT  TestAccVerifiedAccess_serial/Instance_description
=== CONT  TestAccVerifiedAccess_serial/Group_disappears
=== CONT  TestAccVerifiedAccess_serial/Group_updatePolicy
=== CONT  TestAccVerifiedAccess_serial/Group_policy
=== CONT  TestAccVerifiedAccess_serial/Group_tags
=== CONT  TestAccVerifiedAccess_serial/Endpoint_policyDocument
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext
=== CONT  TestAccVerifiedAccess_serial/Instance_fipsEnabled
=== CONT  TestAccVerifiedAccess_serial/Endpoint_rds
=== CONT  TestAccVerifiedAccess_serial/Endpoint_cidr
=== CONT  TestAccVerifiedAccess_serial/Group_setPolicy
=== CONT  TestAccVerifiedAccess_serial/Endpoint_subnetIDs
=== CONT  TestAccVerifiedAccess_serial/Group_updateKMS
=== CONT  TestAccVerifiedAccess_serial/Group_kms
=== CONT  TestAccVerifiedAccess_serial/Group_basic
=== CONT  TestAccVerifiedAccess_serial/Instance_disappears
=== CONT  TestAccVerifiedAccess_serial/Endpoint_tags
=== CONT  TestAccVerifiedAccess_serial/Endpoint_networkInterface
=== CONT  TestAccVerifiedAccess_serial/Endpoint_disappears
--- PASS: TestAccVerifiedAccess_serial (0.63s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_basic (15.37s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion (26.49s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_tags (31.83s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3 (34.99s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears (40.18s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs (40.80s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears (49.14s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic (55.66s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_description (62.25s)
    --- PASS: TestAccVerifiedAccess_serial/Group_disappears (64.64s)
    --- PASS: TestAccVerifiedAccess_serial/Group_policy (80.47s)
    --- PASS: TestAccVerifiedAccess_serial/Group_updatePolicy (87.15s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_cidrEndpointsCustomSubDomain (101.59s)
    --- PASS: TestAccVerifiedAccess_serial/Group_tags (102.01s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext (126.55s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose (131.71s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_fipsEnabled (148.47s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3 (217.66s)
    --- PASS: TestAccVerifiedAccess_serial/Group_setPolicy (217.70s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_basic (673.90s)
    --- PASS: TestAccVerifiedAccess_serial/Group_updateKMS (667.36s)
    --- PASS: TestAccVerifiedAccess_serial/Group_kms (685.30s)
    --- PASS: TestAccVerifiedAccess_serial/Group_basic (695.11s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_disappears (700.64s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_cidr (770.28s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_policyDocument (802.08s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_subnetIDs (789.24s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_tags (1063.18s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_rds (1443.27s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_networkInterface (2024.12s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_disappears (2222.75s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	2309.538s
@ewbankkit
r/aws_verifiedaccess_endpoint: Use AWS SDK for Go v2 enum for 'attach…
f9a8339 
…ment_type'.
@ewbankkit
r/aws_verifiedaccess_endpoint: Use AWS SDK for Go v2 enum for 'cidr_o…
0317a9a 
…ptions.protocol'.
@ewbankkit
r/aws_verifiedaccess_endpoint: Use AWS SDK for Go v2 enum for 'endpoi…
c4dca94 
…nt_type'.
@ewbankkit
r/aws_verifiedaccess_endpoint: Use AWS SDK for Go v2 enum for 'load_b…
5dd9999 
…alancer_options.protocol'.
@ewbankkit
r/aws_verifiedaccess_endpoint: Tidy up.
b6c511c
@ewbankkit
Tweak CHANGELOG entry.
22bc049
@ewbankkit
r/aws_verifiedaccess_endpoint: Correct 'rds_options' configuration bl…
78664f6 
…ock attribute names.
@ewbankkit
r/aws_verifiedaccess_instance: Tidy up.
f89ee04
@ewbankkit
r/aws_verifiedaccess_trust_provider: Tidy up.
88f1c1d
ewbankkit
ewbankkit approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVerifiedAccess_serial' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.7 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVerifiedAccess_serial -timeout 360m -vet=off
2025/03/26 14:33:28 Initializing Terraform AWS Provider...
=== RUN   TestAccVerifiedAccess_serial
=== PAUSE TestAccVerifiedAccess_serial
=== CONT  TestAccVerifiedAccess_serial
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears
=== RUN   TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic
=== PAUSE TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic
=== RUN   TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears
=== PAUSE TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears
=== RUN   TestAccVerifiedAccess_serial/Endpoint_rds
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_rds
=== RUN   TestAccVerifiedAccess_serial/Endpoint_basic
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_basic
=== RUN   TestAccVerifiedAccess_serial/Endpoint_networkInterface
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_networkInterface
=== RUN   TestAccVerifiedAccess_serial/Endpoint_tags
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_tags
=== RUN   TestAccVerifiedAccess_serial/Endpoint_disappears
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_disappears
=== RUN   TestAccVerifiedAccess_serial/Endpoint_policyDocument
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_policyDocument
=== RUN   TestAccVerifiedAccess_serial/Endpoint_subnetIDs
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_subnetIDs
=== RUN   TestAccVerifiedAccess_serial/Endpoint_cidr
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_cidr
=== RUN   TestAccVerifiedAccess_serial/Group_disappears
=== PAUSE TestAccVerifiedAccess_serial/Group_disappears
=== RUN   TestAccVerifiedAccess_serial/Group_tags
=== PAUSE TestAccVerifiedAccess_serial/Group_tags
=== RUN   TestAccVerifiedAccess_serial/Group_policy
=== PAUSE TestAccVerifiedAccess_serial/Group_policy
=== RUN   TestAccVerifiedAccess_serial/Group_updatePolicy
=== PAUSE TestAccVerifiedAccess_serial/Group_updatePolicy
=== RUN   TestAccVerifiedAccess_serial/Group_setPolicy
=== PAUSE TestAccVerifiedAccess_serial/Group_setPolicy
=== RUN   TestAccVerifiedAccess_serial/Group_basic
=== PAUSE TestAccVerifiedAccess_serial/Group_basic
=== RUN   TestAccVerifiedAccess_serial/Group_kms
=== PAUSE TestAccVerifiedAccess_serial/Group_kms
=== RUN   TestAccVerifiedAccess_serial/Group_updateKMS
=== PAUSE TestAccVerifiedAccess_serial/Group_updateKMS
=== RUN   TestAccVerifiedAccess_serial/Instance_basic
=== PAUSE TestAccVerifiedAccess_serial/Instance_basic
=== RUN   TestAccVerifiedAccess_serial/Instance_description
=== PAUSE TestAccVerifiedAccess_serial/Instance_description
=== RUN   TestAccVerifiedAccess_serial/Instance_fipsEnabled
=== PAUSE TestAccVerifiedAccess_serial/Instance_fipsEnabled
=== RUN   TestAccVerifiedAccess_serial/Instance_disappears
=== PAUSE TestAccVerifiedAccess_serial/Instance_disappears
=== RUN   TestAccVerifiedAccess_serial/Instance_tags
=== PAUSE TestAccVerifiedAccess_serial/Instance_tags
=== RUN   TestAccVerifiedAccess_serial/Instance_cidrEndpointsCustomSubDomain
=== PAUSE TestAccVerifiedAccess_serial/Instance_cidrEndpointsCustomSubDomain
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext
=== CONT  TestAccVerifiedAccess_serial/Endpoint_cidr
=== CONT  TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears
=== CONT  TestAccVerifiedAccess_serial/Endpoint_subnetIDs
=== CONT  TestAccVerifiedAccess_serial/Endpoint_policyDocument
=== CONT  TestAccVerifiedAccess_serial/Endpoint_disappears
=== CONT  TestAccVerifiedAccess_serial/Endpoint_tags
=== CONT  TestAccVerifiedAccess_serial/Endpoint_networkInterface
=== CONT  TestAccVerifiedAccess_serial/Endpoint_basic
=== CONT  TestAccVerifiedAccess_serial/Endpoint_rds
=== CONT  TestAccVerifiedAccess_serial/Group_updateKMS
=== CONT  TestAccVerifiedAccess_serial/Instance_cidrEndpointsCustomSubDomain
=== CONT  TestAccVerifiedAccess_serial/Instance_tags
=== CONT  TestAccVerifiedAccess_serial/Instance_disappears
=== CONT  TestAccVerifiedAccess_serial/Instance_fipsEnabled
=== CONT  TestAccVerifiedAccess_serial/Instance_description
=== CONT  TestAccVerifiedAccess_serial/Instance_basic
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3
=== CONT  TestAccVerifiedAccess_serial/Group_updatePolicy
=== CONT  TestAccVerifiedAccess_serial/Group_kms
=== CONT  TestAccVerifiedAccess_serial/Group_basic
=== CONT  TestAccVerifiedAccess_serial/Group_setPolicy
=== CONT  TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic
=== CONT  TestAccVerifiedAccess_serial/Group_tags
=== CONT  TestAccVerifiedAccess_serial/Group_policy
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears
=== CONT  TestAccVerifiedAccess_serial/Group_disappears
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3
--- PASS: TestAccVerifiedAccess_serial (0.66s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext (27.27s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears (41.39s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_policyDocument (1362.65s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_networkInterface (1385.31s)
    --- PASS: TestAccVerifiedAccess_serial/Group_updateKMS (1417.68s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_cidr (1927.87s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_subnetIDs (1938.78s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_cidrEndpointsCustomSubDomain (1952.79s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_tags (1981.74s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_fipsEnabled (2003.44s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_description (2025.08s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs (2051.18s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose (2150.69s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_basic (2164.15s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3 (2197.11s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_disappears (2209.09s)
    --- PASS: TestAccVerifiedAccess_serial/Group_updatePolicy (2213.19s)
    --- PASS: TestAccVerifiedAccess_serial/Group_kms (2217.67s)
    --- PASS: TestAccVerifiedAccess_serial/Group_basic (914.84s)
    --- PASS: TestAccVerifiedAccess_serial/Group_setPolicy (924.16s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic (908.50s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_rds (2340.05s)
    --- PASS: TestAccVerifiedAccess_serial/Group_policy (419.49s)
    --- PASS: TestAccVerifiedAccess_serial/Group_tags (436.08s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears (420.08s)
    --- PASS: TestAccVerifiedAccess_serial/Group_disappears (398.26s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion (394.30s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3 (442.06s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_tags (2816.40s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_disappears (3026.79s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_basic (3348.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	3355.032s

@ewbankkit
Copy link
Contributor

@esteban1983cl Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit bcdb6c0 into hashicorp:main Mar 26, 2025
43 checks passed
@github-actions GitHub Actions
Copy link

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.93.0 milestone Mar 26, 2025
@esteban1983cl esteban1983cl deleted the f-verified-access-update branch March 26, 2025 22:59
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.93.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 27, 2025
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

@jar-b jar-b jar-b approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. linter Pertains to changes to or issues with the various linters. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.93.0
4 participants
@esteban1983cl @ewbankkit @jar-b @Dolape1983