Skip to content

Add aws_workspaces_directory.certificate_based_auth_properties #42269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kevingunn-wk
Copy link
Contributor

Description

Adds the certificate_based_auth_properties structure within the aws_workspaces_directory resource and datasource to allow Terraform to manage the configuration of Certificate-based authentication (CBA) within AWS Workspaces.

Relations

n/a

References

Certificate-based authentication

Output from Acceptance Testing

% make testacc TESTS=TestAccWorkSpacesDataSource_serial/Directory PKG=workspaces
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/workspaces/... -v -count 1 -parallel 20 -run='TestAccWorkSpacesDataSource_serial/Directory'  -timeout 360m -vet=off
2025/04/16 15:01:44 Initializing Terraform AWS Provider...
=== RUN   TestAccWorkSpacesDataSource_serial
=== PAUSE TestAccWorkSpacesDataSource_serial
=== CONT  TestAccWorkSpacesDataSource_serial
=== RUN   TestAccWorkSpacesDataSource_serial/Directory
=== RUN   TestAccWorkSpacesDataSource_serial/Directory/basic
--- PASS: TestAccWorkSpacesDataSource_serial (740.62s)
    --- PASS: TestAccWorkSpacesDataSource_serial/Directory (740.62s)
        --- PASS: TestAccWorkSpacesDataSource_serial/Directory/basic (740.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/workspaces	753.648s
% make testacc TESTS=TestAccWorkSpaces_serial/Directory/basic PKG=workspaces
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/workspaces/... -v -count 1 -parallel 20 -run='TestAccWorkSpaces_serial/Directory/basic'  -timeout 360m -vet=off
2025/04/16 15:15:40 Initializing Terraform AWS Provider...
=== RUN   TestAccWorkSpaces_serial
=== PAUSE TestAccWorkSpaces_serial
=== CONT  TestAccWorkSpaces_serial
=== RUN   TestAccWorkSpaces_serial/Directory
=== RUN   TestAccWorkSpaces_serial/Directory/basic
--- PASS: TestAccWorkSpaces_serial (631.45s)
    --- PASS: TestAccWorkSpaces_serial/Directory (631.45s)
        --- PASS: TestAccWorkSpaces_serial/Directory/basic (631.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/workspaces	642.920s
% make testacc TESTS=TestAccWorkSpaces_serial/Directory/workspaceCertificateBasedAuthProperties PKG=workspaces
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/workspaces/... -v -count 1 -parallel 20 -run='TestAccWorkSpaces_serial/Directory/workspaceCertificateBasedAuthProperties'  -timeout 360m -vet=off
2025/04/16 15:27:24 Initializing Terraform AWS Provider...
=== RUN   TestAccWorkSpaces_serial
=== PAUSE TestAccWorkSpaces_serial
=== CONT  TestAccWorkSpaces_serial
=== RUN   TestAccWorkSpaces_serial/Directory
=== RUN   TestAccWorkSpaces_serial/Directory/workspaceCertificateBasedAuthProperties
--- PASS: TestAccWorkSpaces_serial (769.42s)
    --- PASS: TestAccWorkSpaces_serial/Directory (769.42s)
        --- PASS: TestAccWorkSpaces_serial/Directory/workspaceCertificateBasedAuthProperties (769.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/workspaces	782.652s

@kevingunn-wk kevingunn-wk requested a review from a team as a code owner April 16, 2025 20:25
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/workspaces Issues and PRs that pertain to the workspaces service. size/L Managed by automation to categorize the size of a PR. labels Apr 16, 2025
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 17, 2025
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Apr 30, 2025
@kevingunn-wk kevingunn-wk force-pushed the feat-workspaces-certificate-based-authentication branch from c8d5058 to be69e7a Compare April 30, 2025 02:16
@kevingunn-wk kevingunn-wk force-pushed the feat-workspaces-certificate-based-authentication branch from be69e7a to 33e9d94 Compare April 30, 2025 03:06
ewbankkit
ewbankkit previously approved these changes May 1, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccWorkSpaces_serial/^Directory$$\|TestAccWorkSpacesDataSource_serial/^Directory$$' PKG=workspaces
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/workspaces/... -v -count 1 -parallel 20  -run=TestAccWorkSpaces_serial/^Directory$\|TestAccWorkSpacesDataSource_serial/^Directory$ -timeout 720m -vet=off
2025/04/30 16:00:16 Initializing Terraform AWS Provider...
=== RUN   TestAccWorkSpacesDataSource_serial
=== PAUSE TestAccWorkSpacesDataSource_serial
=== RUN   TestAccWorkSpaces_serial
=== PAUSE TestAccWorkSpaces_serial
=== CONT  TestAccWorkSpacesDataSource_serial
=== CONT  TestAccWorkSpaces_serial
=== RUN   TestAccWorkSpacesDataSource_serial/Directory
=== RUN   TestAccWorkSpacesDataSource_serial/Directory/basic
=== RUN   TestAccWorkSpaces_serial/Directory
=== RUN   TestAccWorkSpaces_serial/Directory/workspaceSamlProperties
--- PASS: TestAccWorkSpacesDataSource_serial (730.55s)
    --- PASS: TestAccWorkSpacesDataSource_serial/Directory (730.54s)
        --- PASS: TestAccWorkSpacesDataSource_serial/Directory/basic (730.54s)
=== RUN   TestAccWorkSpaces_serial/Directory/basic
=== RUN   TestAccWorkSpaces_serial/Directory/disappears
=== RUN   TestAccWorkSpaces_serial/Directory/ipGroupIds
=== RUN   TestAccWorkSpaces_serial/Directory/workspaceAccessProperties
=== RUN   TestAccWorkSpaces_serial/Directory/workspaceCertificateBasedAuthProperties
=== RUN   TestAccWorkSpaces_serial/Directory/selfServicePermissions
=== RUN   TestAccWorkSpaces_serial/Directory/subnetIDs
=== RUN   TestAccWorkSpaces_serial/Directory/tags
=== RUN   TestAccWorkSpaces_serial/Directory/workspaceCreationProperties
=== RUN   TestAccWorkSpaces_serial/Directory/workspaceCreationProperties_customSecurityGroupId_defaultOu
--- PASS: TestAccWorkSpaces_serial (6494.22s)
    --- PASS: TestAccWorkSpaces_serial/Directory (6494.22s)
        --- PASS: TestAccWorkSpaces_serial/Directory/workspaceSamlProperties (884.21s)
        --- PASS: TestAccWorkSpaces_serial/Directory/basic (685.73s)
        --- PASS: TestAccWorkSpaces_serial/Directory/disappears (600.22s)
        --- PASS: TestAccWorkSpaces_serial/Directory/ipGroupIds (602.61s)
        --- PASS: TestAccWorkSpaces_serial/Directory/workspaceAccessProperties (516.40s)
        --- PASS: TestAccWorkSpaces_serial/Directory/workspaceCertificateBasedAuthProperties (620.03s)
        --- PASS: TestAccWorkSpaces_serial/Directory/selfServicePermissions (631.96s)
        --- PASS: TestAccWorkSpaces_serial/Directory/subnetIDs (571.74s)
        --- PASS: TestAccWorkSpaces_serial/Directory/tags (656.94s)
        --- PASS: TestAccWorkSpaces_serial/Directory/workspaceCreationProperties (174.83s)
        --- PASS: TestAccWorkSpaces_serial/Directory/workspaceCreationProperties_customSecurityGroupId_defaultOu (352.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/workspaces	6498.885s

@ewbankkit ewbankkit self-assigned this May 1, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 1, 2025
jar-b
jar-b previously approved these changes May 1, 2025
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

…tatus' as Computed and remove default value.
@ewbankkit ewbankkit dismissed stale reviews from jar-b and themself via f33e20f May 1, 2025 14:58
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit
Copy link
Contributor

@kevingunn-wk Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 1d45e92 into hashicorp:main May 1, 2025
48 checks passed
Copy link

github-actions bot commented May 1, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.97.0 milestone May 1, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 1, 2025
Copy link

github-actions bot commented May 1, 2025

This functionality has been released in v5.97.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jun 1, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/workspaces Issues and PRs that pertain to the workspaces service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants