-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Add aws_workspaces_directory.certificate_based_auth_properties #42269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aws_workspaces_directory.certificate_based_auth_properties #42269
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
c8d5058
to
be69e7a
Compare
be69e7a
to
33e9d94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccWorkSpaces_serial/^Directory$$\|TestAccWorkSpacesDataSource_serial/^Directory$$' PKG=workspaces
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/workspaces/... -v -count 1 -parallel 20 -run=TestAccWorkSpaces_serial/^Directory$\|TestAccWorkSpacesDataSource_serial/^Directory$ -timeout 720m -vet=off
2025/04/30 16:00:16 Initializing Terraform AWS Provider...
=== RUN TestAccWorkSpacesDataSource_serial
=== PAUSE TestAccWorkSpacesDataSource_serial
=== RUN TestAccWorkSpaces_serial
=== PAUSE TestAccWorkSpaces_serial
=== CONT TestAccWorkSpacesDataSource_serial
=== CONT TestAccWorkSpaces_serial
=== RUN TestAccWorkSpacesDataSource_serial/Directory
=== RUN TestAccWorkSpacesDataSource_serial/Directory/basic
=== RUN TestAccWorkSpaces_serial/Directory
=== RUN TestAccWorkSpaces_serial/Directory/workspaceSamlProperties
--- PASS: TestAccWorkSpacesDataSource_serial (730.55s)
--- PASS: TestAccWorkSpacesDataSource_serial/Directory (730.54s)
--- PASS: TestAccWorkSpacesDataSource_serial/Directory/basic (730.54s)
=== RUN TestAccWorkSpaces_serial/Directory/basic
=== RUN TestAccWorkSpaces_serial/Directory/disappears
=== RUN TestAccWorkSpaces_serial/Directory/ipGroupIds
=== RUN TestAccWorkSpaces_serial/Directory/workspaceAccessProperties
=== RUN TestAccWorkSpaces_serial/Directory/workspaceCertificateBasedAuthProperties
=== RUN TestAccWorkSpaces_serial/Directory/selfServicePermissions
=== RUN TestAccWorkSpaces_serial/Directory/subnetIDs
=== RUN TestAccWorkSpaces_serial/Directory/tags
=== RUN TestAccWorkSpaces_serial/Directory/workspaceCreationProperties
=== RUN TestAccWorkSpaces_serial/Directory/workspaceCreationProperties_customSecurityGroupId_defaultOu
--- PASS: TestAccWorkSpaces_serial (6494.22s)
--- PASS: TestAccWorkSpaces_serial/Directory (6494.22s)
--- PASS: TestAccWorkSpaces_serial/Directory/workspaceSamlProperties (884.21s)
--- PASS: TestAccWorkSpaces_serial/Directory/basic (685.73s)
--- PASS: TestAccWorkSpaces_serial/Directory/disappears (600.22s)
--- PASS: TestAccWorkSpaces_serial/Directory/ipGroupIds (602.61s)
--- PASS: TestAccWorkSpaces_serial/Directory/workspaceAccessProperties (516.40s)
--- PASS: TestAccWorkSpaces_serial/Directory/workspaceCertificateBasedAuthProperties (620.03s)
--- PASS: TestAccWorkSpaces_serial/Directory/selfServicePermissions (631.96s)
--- PASS: TestAccWorkSpaces_serial/Directory/subnetIDs (571.74s)
--- PASS: TestAccWorkSpaces_serial/Directory/tags (656.94s)
--- PASS: TestAccWorkSpaces_serial/Directory/workspaceCreationProperties (174.83s)
--- PASS: TestAccWorkSpaces_serial/Directory/workspaceCreationProperties_customSecurityGroupId_defaultOu (352.94s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/workspaces 6498.885s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
…tatus' as Computed and remove default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@kevingunn-wk Thanks for the contribution 🎉 👏. |
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
This functionality has been released in v5.97.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds the
certificate_based_auth_properties
structure within theaws_workspaces_directory
resource and datasource to allow Terraform to manage the configuration of Certificate-based authentication (CBA) within AWS Workspaces.Relations
n/a
References
Certificate-based authentication
Output from Acceptance Testing