fix: respect logs setting if initialization fails

Author: Lubos ​

.changeset/mighty-bulldogs-kiss.md

@@ -0,0 +1,5 @@
+---
+'@hey-api/openapi-ts': patch
+---
+
+fix: respect logs setting if initialization fails

packages/openapi-ts-tests/test/bin.test.ts

@@ -164,23 +164,6 @@ describe('bin', () => {
     );
   });
 
-  it('throws error with wrong client', () => {
-    const result = sync('node', [
-      path.resolve(__dirname, '..', '..', 'openapi-ts', 'bin', 'index.cjs'),
-      '--input',
-      path.resolve(__dirname, 'spec', 'v3.json'),
-      '--output',
-      path.resolve(__dirname, 'generated', 'bin'),
-      '--client',
-      'invalid/client',
-      '--dry-run',
-      'true',
-    ]);
-    expect(result.stdout.toString()).toBe('');
-    expect(result.stderr.toString()).toContain('encountered an error');
-    expect(result.stderr.toString()).toContain('client needs to be set');
-  });
-
   it('displays help', () => {
     const result = sync('node', [
       path.resolve(__dirname, '..', '..', 'openapi-ts', 'bin', 'index.cjs'),

packages/openapi-ts/src/index.ts

@@ -32,13 +32,18 @@ export const createClient = async (
   const resolvedConfig =
     typeof userConfig === 'function' ? await userConfig() : userConfig;
 
-  let configs: Config[] = [];
+  const configs: Array<Config> = [];
 
   try {
     Performance.start('createClient');
 
     Performance.start('config');
-    configs = await initConfigs(resolvedConfig);
+    for (const result of await initConfigs(resolvedConfig)) {
+      configs.push(result.config);
+      if (result.errors.length) {
+        throw result.errors[0];
+      }
+    }
     Performance.end('config');
 
     Performance.start('handlebars');

packages/openapi-ts/src/initConfigs.ts

@@ -332,7 +332,12 @@ const mergeConfigs = (
  */
 export const initConfigs = async (
   userConfig: UserConfig | undefined,
-): Promise<Config[]> => {
+): Promise<
+  ReadonlyArray<{
+    config: Config;
+    errors: ReadonlyArray<Error>;
+  }>
+> => {
   let configurationFile: string | undefined = undefined;
   if (userConfig?.configFile) {
     const parts = userConfig.configFile.split('.');
@@ -350,7 +355,12 @@ export const initConfigs = async (
       ? configFromFile.map((config) => mergeConfigs(config, userConfig))
       : [mergeConfigs(configFromFile, userConfig)];
 
-  return userConfigs.map((userConfig) => {
+  const results: Array<{
+    config: Config;
+    errors: Array<Error>;
+  }> = [];
+
+  for (const userConfig of userConfigs) {
     const {
       base,
       configFile = '',
@@ -362,6 +372,8 @@ export const initConfigs = async (
       useOptions = true,
     } = userConfig;
 
+    const errors: Array<Error> = [];
+
     const logs = getLogs(userConfig);
 
     if (logs.level === 'debug') {
@@ -372,13 +384,17 @@ export const initConfigs = async (
     const output = getOutput(userConfig);
 
     if (!input.path) {
-      throw new Error(
-        'missing input - which OpenAPI specification should we use to generate your output?',
+      errors.push(
+        new Error(
+          'missing input - which OpenAPI specification should we use to generate your output?',
+        ),
       );
     }
 
     if (!output.path) {
-      throw new Error('missing output - where should we generate your output?');
+      errors.push(
+        new Error('missing output - where should we generate your output?'),
+      );
     }
 
     if (!useOptions) {
@@ -389,8 +405,20 @@ export const initConfigs = async (
 
     output.path = path.resolve(process.cwd(), output.path);
 
+    let plugins: Pick<Config, 'plugins' | 'pluginOrder'>;
+
+    try {
+      plugins = getPlugins(userConfig);
+    } catch (error) {
+      errors.push(error);
+      plugins = {
+        pluginOrder: [],
+        plugins: {},
+      };
+    }
+
     const config = setConfig({
-      ...getPlugins(userConfig),
+      ...plugins,
       base,
       configFile,
       dryRun,
@@ -409,6 +437,11 @@ export const initConfigs = async (
       console.warn('config:', config);
     }
 
-    return config;
-  });
+    results.push({
+      config,
+      errors,
+    });
+  }
+
+  return results;
 };