HHH-18837 Oracle epoch extraction doesn't work with dates

Author: peter1123581321

hibernate-core/src/main/java/org/hibernate/dialect/OracleDialect.java

@@ -418,6 +418,8 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio
 		functionFactory.hex( "rawtohex(?1)" );
 		functionFactory.sha( "standard_hash(?1, 'SHA256')" );
 		functionFactory.md5( "standard_hash(?1, 'MD5')" );
+
+		functionFactory.extract_oracle( this );
 	}
 
 	/**
@@ -624,7 +626,6 @@ public String extractPattern(TemporalUnit unit) {
 			case HOUR -> "to_number(to_char(?2,'HH24'))";
 			case MINUTE -> "to_number(to_char(?2,'MI'))";
 			case SECOND -> "to_number(to_char(?2,'SS'))";
-			case EPOCH -> "trunc((cast(?2 at time zone 'UTC' as date) - date '1970-1-1')*86400)";
 			default -> super.extractPattern(unit);
 		};
 	}

hibernate-core/src/main/java/org/hibernate/dialect/function/CommonFunctionFactory.java

@@ -4403,4 +4403,11 @@ public void xmltable_sqlserver() {
 	public void xmltable_sybasease() {
 		functionRegistry.register( "xmltable", new SybaseASEXmlTableFunction( typeConfiguration ) );
 	}
+
+	/**
+	 * Oracle extract() function
+	 */
+	public void extract_oracle(Dialect dialect) {
+		functionRegistry.register( "extract", new OracleExtractFunction( dialect, typeConfiguration ) );
+	}
 }

hibernate-core/src/main/java/org/hibernate/dialect/function/ExtractFunction.java

@@ -48,7 +48,7 @@
  */
 public class ExtractFunction extends AbstractSqmFunctionDescriptor implements FunctionRenderer {
 
-	private final Dialect dialect;
+	protected final Dialect dialect;
 
 	public ExtractFunction(Dialect dialect, TypeConfiguration typeConfiguration) {
 		super(

hibernate-core/src/main/java/org/hibernate/dialect/function/OracleExtractFunction.java

@@ -0,0 +1,51 @@
+/*
+ * SPDX-License-Identifier: Apache-2.0
+ * Copyright Red Hat Inc. and Hibernate Authors
+ */
+package org.hibernate.dialect.function;
+
+import jakarta.persistence.TemporalType;
+import org.hibernate.dialect.Dialect;
+import org.hibernate.metamodel.model.domain.ReturnableType;
+import org.hibernate.query.common.TemporalUnit;
+import org.hibernate.query.sqm.produce.function.internal.PatternRenderer;
+import org.hibernate.sql.ast.SqlAstTranslator;
+import org.hibernate.sql.ast.spi.SqlAppender;
+import org.hibernate.sql.ast.tree.SqlAstNode;
+import org.hibernate.sql.ast.tree.expression.Expression;
+import org.hibernate.sql.ast.tree.expression.ExtractUnit;
+import org.hibernate.type.spi.TypeConfiguration;
+
+import java.util.List;
+
+import static org.hibernate.type.spi.TypeConfiguration.getSqlTemporalType;
+
+public class OracleExtractFunction extends ExtractFunction {
+	public OracleExtractFunction(Dialect dialect, TypeConfiguration typeConfiguration) {
+		super( dialect, typeConfiguration );
+	}
+
+	@Override
+	public void render(
+			SqlAppender sqlAppender,
+			List<? extends SqlAstNode> sqlAstArguments,
+			ReturnableType<?> returnType,
+			SqlAstTranslator<?> walker) {
+		new PatternRenderer( extractPattern( sqlAstArguments ) ).render( sqlAppender, sqlAstArguments, walker );
+	}
+
+	@SuppressWarnings("deprecation")
+	private String extractPattern(List<? extends SqlAstNode> sqlAstArguments) {
+		final ExtractUnit field = (ExtractUnit) sqlAstArguments.get( 0 );
+		final TemporalUnit unit = field.getUnit();
+		final Expression expression = (Expression) sqlAstArguments.get( 1 );
+		final TemporalType temporalType;
+		if ( unit.equals( TemporalUnit.EPOCH ) && (temporalType = getSqlTemporalType(
+				expression.getExpressionType() )) != null ) {
+			return temporalType == TemporalType.DATE
+					? "trunc((cast(from_tz(cast(?2 as timestamp),'UTC') as date) - date '1970-1-1')*86400)"
+					: "trunc((cast(?2 at time zone 'UTC' as date) - date '1970-1-1')*86400)";
+		}
+		return dialect.extractPattern( unit );
+	}
+}

hibernate-core/src/test/java/org/hibernate/orm/test/query/hql/FunctionTests.java

@@ -58,7 +58,9 @@
 import java.time.LocalDateTime;
 import java.time.LocalTime;
 import java.time.OffsetDateTime;
+import java.time.ZoneId;
 import java.time.ZoneOffset;
+import java.time.ZonedDateTime;
 import java.time.temporal.ChronoUnit;
 import java.util.Date;
 import java.util.List;
@@ -2644,4 +2646,40 @@ public void testHexFunction(SessionFactoryScope scope) {
 							.getSingleResult().toUpperCase( Locale.ROOT ) );
 		});
 	}
+
+	@Test
+	@JiraKey("HHH-18837")
+	public void testEpochFunction(SessionFactoryScope scope) {
+
+		LocalDate someLocalDate = LocalDate.of( 2013, 7, 5 );
+		LocalDateTime someLocalDateTime = someLocalDate.atStartOfDay();
+		Date someDate = Date.from( someLocalDateTime.toInstant( ZoneOffset.UTC ) );
+		ZonedDateTime someZonedDateTime = ZonedDateTime.of( someLocalDate, LocalTime.MIN,
+				ZoneId.of( "Europe/Vienna" ) );
+
+		scope.inTransaction( session -> {
+			EntityOfBasics entityOfBasics = new EntityOfBasics();
+			entityOfBasics.setId( 124 );
+			entityOfBasics.setTheDate( someDate );
+			entityOfBasics.setTheLocalDate( someLocalDate );
+			entityOfBasics.setTheLocalDateTime( someLocalDateTime );
+			entityOfBasics.setTheZonedDateTime( someZonedDateTime );
+			session.persist( entityOfBasics );
+
+			assertEquals( someDate.toInstant().toEpochMilli() / 1000,
+					session.createSelectionQuery( "select epoch(a.theDate) from EntityOfBasics a where id=124",
+							Long.class ).getSingleResult() );
+			assertEquals( someLocalDate.atStartOfDay( ZoneOffset.UTC ).toInstant().toEpochMilli() / 1000,
+					session.createSelectionQuery( "select epoch(a.theLocalDate) from EntityOfBasics a where id=124",
+							Long.class ).getSingleResult() );
+			assertEquals( someLocalDateTime.toEpochSecond( ZoneOffset.UTC ), session.createSelectionQuery(
+					"select epoch(a.theLocalDateTime) from EntityOfBasics a where id=124",
+					Long.class ).getSingleResult() );
+			assertEquals( someZonedDateTime.toEpochSecond(), session.createSelectionQuery(
+					"select epoch(a.theZonedDateTime) from EntityOfBasics a where id=124",
+					Long.class ).getSingleResult() );
+
+			session.remove( entityOfBasics );
+		} );
+	}
 }