homebridge-sinricpro

[kakopappa]

Link To GitHub Repo

https://github.com/sinricpro/homebridge-sinricpro

Link To NPM Package

https://www.npmjs.com/package/homebridge-sinricpro

Plugin Icon (Optional)

[github-actions]

✅ Pre-checks completed successfully.

[github-actions]

• General
  • The plugin must be of type dynamic platform.
  • The plugin must not offer the same nor less functionality than that of any existing verified plugin.
• Repo
  • The plugin must be published to NPM and the source code available on a GitHub repository, with issues enabled.
  • A GitHub release should be created for every new version of your plugin, with release notes.
• Environment
  • The plugin must run on all supported LTS versions of Node.js, at the time of writing this is Node v18 and v20.
  • The plugin must successfully install and not start unless it is configured.
  • The plugin must not execute post-install scripts that modify the users' system in any way.
  • The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
• Codebase
  • The plugin must implement the Homebridge Plugin Settings GUI.
  • The plugin must not contain any analytics or calls that enable you to track the user.
  • If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.
  • The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.

---

---

Comment /check to run checks again.

[github-actions]

Congratulations! Your plugin has been verified.

You can now add one of the Verified by Homebridge badges to your plugin's README:

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

[![verified-by-homebridge](https://img.shields.io/badge/homebridge-verified-blueviolet?color=%23491F59&style=for-the-badge&logoColor=%23FFFFFF&logo=homebridge)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions.

If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel!

Thank you for your contribution to the Homebridge Community.
https://homebridge.io

[bwp91]

Hi @kakopappa couple of things to suggest, although not required for verification :)

1. Adding some keywords here:
   • https://github.com/sinricpro/homebridge-sinricpro/blob/f6c0c2c3349c48b9bdd0229b56cab8ab12e14ae2/package.json#L25
2. Your check here is only checking if the token is null, ie not checking for undefined or empty string, maybe you could even check for a valid length of a token
   • https://github.com/sinricpro/homebridge-sinricpro/blob/f6c0c2c3349c48b9bdd0229b56cab8ab12e14ae2/src/platform.ts#L51

   if (!config.token || config.token.length !== 28) { // 28 is just an example

[kakopappa]

@bwp91 Thanks