Skip to content

Commit b1ae79d

Browse files
committed
fixup! Replaced versioned value for get state
Signed-off-by: Angelo De Caro <[email protected]>
1 parent 91ffd47 commit b1ae79d

File tree

17 files changed

+245
-233
lines changed

17 files changed

+245
-233
lines changed

platform/common/core/generic/vault/db_helpers.go

Lines changed: 24 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -14,31 +14,30 @@ import (
1414
"github.com/hyperledger-labs/fabric-smart-client/platform/common/core/generic/vault/txidstore/mocks"
1515
"github.com/hyperledger-labs/fabric-smart-client/platform/common/utils"
1616
"github.com/hyperledger-labs/fabric-smart-client/platform/view/services/db"
17-
"github.com/hyperledger-labs/fabric-smart-client/platform/view/services/db/driver"
18-
"github.com/hyperledger-labs/fabric-smart-client/platform/view/services/db/driver/sql"
17+
_ "github.com/hyperledger-labs/fabric-smart-client/platform/view/services/db/driver/sql"
1918
"github.com/hyperledger-labs/fabric-smart-client/platform/view/services/db/driver/sql/common"
20-
common2 "github.com/hyperledger-labs/fabric-smart-client/platform/view/services/db/driver/sql/postgres"
19+
"github.com/hyperledger-labs/fabric-smart-client/platform/view/services/db/driver/sql/postgres"
2120
"github.com/pkg/errors"
2221
)
2322

2423
type opener[V any] func(driverName, dataSourceName string, config db.Config) (V, error)
2524

26-
func OpenMemoryVersioned() (driver.VersionedPersistence, error) {
27-
return openMemory[driver.VersionedPersistence](db.OpenVersioned)
25+
func OpenMemoryVersioned() (*db.VersionedPersistence, error) {
26+
return openMemory[*db.VersionedPersistence](db.OpenVersioned)
2827
}
29-
func OpenMemory() (driver.UnversionedPersistence, error) {
30-
return openMemory[driver.UnversionedPersistence](db.Open)
28+
func OpenMemory() (*db.UnversionedPersistence, error) {
29+
return openMemory[*db.UnversionedPersistence](db.Open)
3130
}
3231

3332
func openMemory[V any](open opener[V]) (V, error) {
3433
return open("memory", "", nil)
3534
}
3635

37-
func OpenBadgerVersioned(tempDir, dir string) (driver.VersionedPersistence, error) {
38-
return openBadger[driver.VersionedPersistence](tempDir, dir, db.OpenVersioned)
36+
func OpenBadgerVersioned(tempDir, dir string) (*db.VersionedPersistence, error) {
37+
return openBadger[*db.VersionedPersistence](tempDir, dir, db.OpenVersioned)
3938
}
40-
func OpenBadger(tempDir, dir string) (driver.UnversionedPersistence, error) {
41-
return openBadger[driver.UnversionedPersistence](tempDir, dir, db.Open)
39+
func OpenBadger(tempDir, dir string) (*db.UnversionedPersistence, error) {
40+
return openBadger[*db.UnversionedPersistence](tempDir, dir, db.Open)
4241
}
4342

4443
func openBadger[V any](tempDir, dir string, open opener[V]) (V, error) {
@@ -62,44 +61,42 @@ func (c *dbConfig) UnmarshalKey(key string, rawVal interface{}) error {
6261
return errors.New("invalid pointer type")
6362
}
6463

65-
type driverOpener[V any] func(dataSourceName string, config driver.Config) (V, error)
66-
67-
func OpenSqliteVersioned(key, tempDir string) (driver.VersionedPersistence, error) {
68-
return openSqlite[driver.VersionedPersistence](key, tempDir, (&sql.Driver{}).NewVersioned)
64+
func OpenSqliteVersioned(key, tempDir string) (*db.VersionedPersistence, error) {
65+
return openSqlite[*db.VersionedPersistence](key, tempDir, db.OpenVersioned)
6966
}
70-
func OpenSqlite(key, tempDir string) (driver.UnversionedPersistence, error) {
71-
return openSqlite[driver.UnversionedPersistence](key, tempDir, (&sql.Driver{}).NewUnversioned)
67+
func OpenSqlite(key, tempDir string) (*db.UnversionedPersistence, error) {
68+
return openSqlite[*db.UnversionedPersistence](key, tempDir, db.Open)
7269
}
7370

74-
func openSqlite[V any](key, tempDir string, open driverOpener[V]) (V, error) {
71+
func openSqlite[V any](key, tempDir string, open opener[V]) (V, error) {
7572
conf := &dbConfig{
7673
Driver: "sqlite",
7774
DataSource: fmt.Sprintf("%s.sqlite", path.Join(tempDir, key)),
7875
MaxOpenConns: 0,
7976
SkipPragmas: false,
8077
}
81-
return open("test_table", conf)
78+
return open("sql", "test_table", conf)
8279
}
8380

84-
func OpenPostgresVersioned(name string) (driver.VersionedPersistence, func(), error) {
85-
return openPostgres[driver.VersionedPersistence](name, (&sql.Driver{}).NewVersioned)
81+
func OpenPostgresVersioned(name string) (*db.VersionedPersistence, func(), error) {
82+
return openPostgres[*db.VersionedPersistence](name, db.OpenVersioned)
8683
}
87-
func OpenPostgres(name string) (driver.UnversionedPersistence, func(), error) {
88-
return openPostgres[driver.UnversionedPersistence](name, (&sql.Driver{}).NewUnversioned)
84+
func OpenPostgres(name string) (*db.UnversionedPersistence, func(), error) {
85+
return openPostgres[*db.UnversionedPersistence](name, db.Open)
8986
}
9087

91-
func openPostgres[V any](name string, open driverOpener[V]) (V, func(), error) {
92-
postgresConfig := common2.DefaultConfig(fmt.Sprintf("%s-db", name))
88+
func openPostgres[V any](name string, open opener[V]) (V, func(), error) {
89+
postgresConfig := postgres.DefaultConfig(fmt.Sprintf("%s-db", name))
9390
conf := &dbConfig{
9491
Driver: "postgres",
9592
DataSource: postgresConfig.DataSource(),
9693
MaxOpenConns: 50,
9794
SkipPragmas: false,
9895
}
99-
terminate, err := common2.StartPostgresWithFmt(map[string]*common2.PostgresConfig{name: postgresConfig})
96+
terminate, err := postgres.StartPostgresWithFmt(map[string]*postgres.PostgresConfig{name: postgresConfig})
10097
if err != nil {
10198
return utils.Zero[V](), func() {}, err
10299
}
103-
persistence, err := open("test_table", conf)
100+
persistence, err := open("sql", "test_table", conf)
104101
return persistence, terminate, err
105102
}

0 commit comments

Comments
 (0)