Skip to content

Commit ac4334a

Browse files
committed
updated comments
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
1 parent 59d66a4 commit ac4334a

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/AbstractBlockParameterOrBlockHashMethod.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,11 +109,10 @@ protected Object handleParamTypes(final JsonRpcRequestContext requestContext) {
109109
} else if (blockParameterOrBlockHash.isNumeric() || blockParameterOrBlockHash.isEarliest()) {
110110
final OptionalLong blockNumber = blockParameterOrBlockHash.getNumber();
111111
if (blockNumber.isEmpty() || blockNumber.getAsLong() < 0) {
112-
// TODO should this be null result or invalid params?
113112
return new JsonRpcErrorResponse(
114113
requestContext.getRequest().getId(), RpcErrorType.INVALID_BLOCK_NUMBER_PARAMS);
115114
} else if (blockNumber.getAsLong() > getBlockchainQueries().headBlockNumber()) {
116-
// return null if a future block is requested
115+
// return block not found if a future block is requested
117116
return blockNotFoundResponse(requestContext);
118117
}
119118

0 commit comments

Comments
 (0)