Skip to content

Change CustomForks -> Transitions#193

Merged
shemnon merged 1 commit intobesu-eth:masterfrom
shemnon:transitions
Nov 17, 2019
Merged

Change CustomForks -> Transitions#193
shemnon merged 1 commit intobesu-eth:masterfrom
shemnon:transitions

Conversation

@shemnon
Copy link
Copy Markdown
Contributor

@shemnon shemnon commented Nov 16, 2019

Change the configuration name of "CustomForks" to "Transitions." This
will better reflect that this is a list of blocks where transition
events might happen. These may be more than forks, and mainnet is also
moving away from the name forks to "network upgrades." Transitions is
more general purpose.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>

Change the configuration name of "CustomForks" to "Transitions."  This
will better reflect that this is a list of blocks where transition
events might happen.  These may be more than forks, and mainnet is also
moving away from the name forks to "network upgrades."  Transitions is
more general purpose.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
@shemnon shemnon requested a review from rain-on November 16, 2019 21:12
Copy link
Copy Markdown
Contributor

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@rain-on rain-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shemnon shemnon merged commit 503a4a7 into besu-eth:master Nov 17, 2019
@shemnon shemnon deleted the transitions branch November 17, 2019 02:31
edwardmack pushed a commit to ChainSafe/besu that referenced this pull request Feb 4, 2020
Change the configuration name of "CustomForks" to "Transitions."  This
will better reflect that this is a list of blocks where transition
events might happen.  These may be more than forks, and mainnet is also
moving away from the name forks to "network upgrades."  Transitions is
more general purpose.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
edwardmack pushed a commit to ChainSafe/besu that referenced this pull request Feb 4, 2020
Change the configuration name of "CustomForks" to "Transitions."  This
will better reflect that this is a list of blocks where transition
events might happen.  These may be more than forks, and mainnet is also
moving away from the name forks to "network upgrades."  Transitions is
more general purpose.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: edwardmack <ed@edwardmack.com>
siladu pushed a commit to siladu/besu that referenced this pull request Oct 28, 2024
garyschulte added a commit to garyschulte/besu that referenced this pull request Mar 4, 2025
Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants