Merged
Conversation
|
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
ahamlat
force-pushed
the
improve-high-spec-flag
branch
from
f9dc86b to
0081a0d
Compare
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
ahamlat
changed the title
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: ahamlat <ameziane.hamlat@consensys.net>
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
…rove-high-spec-flag
Signed-off-by: ahamlat <ameziane.hamlat@consensys.net>
ahamlat
changed the title
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
garyschulte
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Improve the high spec flag, limit it to few column families * Update changelog * spotless * Update the plugin API hash as one of the interfaces was changed\ * Fix failing unit tests Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Improve the high spec flag (
Xplugin-rocksdb-high-spec-enabled) by limiting it to only few column families.We can see below the difference in memory usage with this new implementation
Fixed Issue(s)