Eth call with 4844 params by macfarla · Pull Request #6661 · besu-eth/besu

macfarla · 2024-03-01T07:28:35Z

Added support for maxFeePerBlobGas and versionedHashes to eth_call

Thanks for sending a pull request! Have you done the following?

Checked out our contribution guidelines?
Considered documentation and added the doc-change-required label to this PR if updates are required.
Considered the changelog and included an update if required.
For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Most advanced CI tests are deferred until PR approval, but you could:

locally run all unit tests via: ./gradlew build
locally run all acceptance tests via: ./gradlew acceptanceTest
locally run all integration tests via: ./gradlew integrationTest
locally run all reference tests via: ./gradlew ethereum:referenceTests:referenceTests

PR description

Fixed Issue(s)

refs #6657

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

macfarla · 2024-03-04T03:03:59Z

Still some debate over which exact fields should be included. Geth includes maxFeePerBlobGas and blobVersionedHashes but not blobs. ~~I included blobs as well since it's in the spec but don't do anything with it other than pass it through.~~ took it out again

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> This reverts commit 0c40e45.

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

shemnon

LGTM, but I have some questions about the Integration Tests.

All the integration tests just null out the parameters (the transaction simulator does pass in real values, so the code is exercised by tests). Should there be at least one integration test that passes in a non-null pair to validate via integration? If not what purpose do the integration tests provide? Should they be removed if they are not keeping pace with the evolution of the APIs they are testing?

siladu

Maybe not in this PR but do we need to update GraphQL with this as well? Not sure if/what the equivalent of eth_call is for GQL.

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

macfarla · 2024-03-05T05:17:42Z

LGTM, but I have some questions about the Integration Tests.

All the integration tests just null out the parameters (the transaction simulator does pass in real values, so the code is exercised by tests). Should there be at least one integration test that passes in a non-null pair to validate via integration? If not what purpose do the integration tests provide? Should they be removed if they are not keeping pace with the evolution of the APIs they are testing?

had a quick look at this - current eth call integration tests are only testing frontier and london forks. think this has kind of been superseded by the spec tests

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* use accessList in hash and equals * add blob fields to callParams * blob fields from callParam used in transaction simulator * don't zero maxFeePerBlobs if not present * add roundtrip callParam verification * added a failure case test * error conversion * added some spec tests Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>

* use accessList in hash and equals * add blob fields to callParams * blob fields from callParam used in transaction simulator * don't zero maxFeePerBlobs if not present * add roundtrip callParam verification * added a failure case test * error conversion * added some spec tests Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>

* use accessList in hash and equals * add blob fields to callParams * blob fields from callParam used in transaction simulator * don't zero maxFeePerBlobs if not present * add roundtrip callParam verification * added a failure case test * error conversion * added some spec tests Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

macfarla added 8 commits March 1, 2024 15:20

use accessList in hash and equals

0e41e28

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

add blob fields to callParams

0eed8fa

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

blob fields from callParam used in transaction simulator

deca732

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

Merge branch 'main' of github.com:hyperledger/besu into eth-call-4844

f63c5a3

don't zero maxFeePerBlobs if not present

0480702

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

fake hash in test

db3284c

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

add blobs to callParams

0c40e45

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

Merge branch 'main' of github.com:hyperledger/besu into eth-call-4844

49b68d0

macfarla added 6 commits March 4, 2024 13:08

added changelog entry

3f96121

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

Revert "add blobs to callParams"

4012ac5

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> This reverts commit 0c40e45.

fixed test

8e5d930

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

add roundtrip callParam verification

477c835

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

added a failure case test

25f346b

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

integration tests

4e1d0ce

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

macfarla added the doc-change-required Indicates an issue or PR that requires doc to be updated label Mar 4, 2024

macfarla marked this pull request as ready for review March 4, 2024 04:51

macfarla added 2 commits March 4, 2024 15:14

spotless for integration tests

a298fcd

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

removed toDo

2c234c3

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

shemnon approved these changes Mar 4, 2024

View reviewed changes

siladu approved these changes Mar 4, 2024

View reviewed changes

macfarla added 3 commits March 5, 2024 14:21

error conversion

5c90e51

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

added some spec tests

556c7e9

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

Merge branch 'main' of github.com:hyperledger/besu into eth-call-4844

fdb21fd

Gabriel-Trintinalia approved these changes Mar 5, 2024

View reviewed changes

macfarla enabled auto-merge (squash) March 5, 2024 05:34

merge

2200855

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

macfarla merged commit cea2099 into besu-eth:main Mar 5, 2024

macfarla mentioned this pull request Mar 5, 2024

RC4 - eth_call and eth_feeHistory add blob fields #6681

Merged

8 tasks

joaniekube mentioned this pull request Mar 7, 2024

Update eth_call and eth_feeHistory to include blob fields besu-eth/besu-docs#1532

Closed

joaniekube removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Mar 7, 2024

macfarla mentioned this pull request Mar 15, 2024

Integration tests - update or remove #6739

Closed

macfarla deleted the eth-call-4844 branch July 16, 2024 02:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Eth call with 4844 params#6661

Eth call with 4844 params#6661
macfarla merged 20 commits intobesu-eth:mainfrom
macfarla:eth-call-4844

macfarla commented Mar 1, 2024 •

edited

Loading

Uh oh!

macfarla commented Mar 4, 2024 •

edited

Loading

Uh oh!

shemnon left a comment

Uh oh!

siladu left a comment

Uh oh!

macfarla commented Mar 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

macfarla commented Mar 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thanks for sending a pull request! Have you done the following?

Most advanced CI tests are deferred until PR approval, but you could:

PR description

Fixed Issue(s)

Uh oh!

macfarla commented Mar 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shemnon left a comment

Choose a reason for hiding this comment

Uh oh!

siladu left a comment

Choose a reason for hiding this comment

Uh oh!

macfarla commented Mar 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

macfarla commented Mar 1, 2024 •

edited

Loading

macfarla commented Mar 4, 2024 •

edited

Loading