Make block txs selection max time aware of PoA transitions#6676
Merged
fab-10 merged 4 commits intobesu-eth:mainfrom Mar 12, 2024
Merged
Conversation
fab-10
force-pushed
the
poa-block-txs-selection-max-time-transaction-aware
branch
from
a53c184 to
b6cd237
Compare
fab-10
changed the title
fab-10
force-pushed
the
poa-block-txs-selection-max-time-transaction-aware
branch
from
b6cd237 to
df163ff
Compare
siladu
approved these changes
Mar 5, 2024
Contributor
siladu
left a comment
siladu
left a comment
There was a problem hiding this comment.
Wiring runtime values into MiningParameters is making me think twice, but seems there is a precedent for it already.
Also the way the block period is set on MiningParameters but I don't feel too strongly about it.
Other than that, PR looks good :)
.../src/main/java/org/hyperledger/besu/consensus/clique/blockcreation/CliqueBlockScheduler.java
Outdated
Show resolved
Hide resolved
fab-10
changed the title
fab-10
force-pushed
the
poa-block-txs-selection-max-time-transaction-aware
branch
from
8da2a03 to
a7b5b2f
Compare
jframe
reviewed
Mar 7, 2024
| forksSchedule.getFork(blockNum).getValue().getMiningBeneficiary().orElse(localAddress); | ||
| } | ||
|
|
||
| private void setBlockPeriodSeconds( |
Contributor
There was a problem hiding this comment.
Moving this into the controller same way you did with Clique would be nicer
Contributor
Author
There was a problem hiding this comment.
done, please re-review
fab-10
force-pushed
the
poa-block-txs-selection-max-time-transaction-aware
branch
from
66c1576 to
216c405
Compare
jframe
approved these changes
Mar 12, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
poa-block-txs-selection-max-time-transaction-aware
branch
from
216c405 to
48af465
Compare
MASDXI
pushed a commit
to MASDXI/besu
that referenced
this pull request
Mar 13, 2024
…6676) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: MASDXI <sirawitt42@gmail.com>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
…6676) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Most advanced CI tests are deferred until PR approval, but you could:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTestsPR description
As a follow up of #6596 this PR makes the block txs selection max time, correctly aware of the PoA transitions, while before only the block period from the genesis was used, while that value can change according to the transitions defined in the genesis file. To support that the
genesisBlockPeriodSecondshas been renamed toblockPeriodSecondsand the configuration is now modifiable at runtime, according to the transitions schedule.Fixed Issue(s)