Changetxpool_beusPendingTransactions:numResults from a required parameter to an optional parameter #6708
Merged
fab-10 merged 16 commits intobesu-eth:mainfrom Mar 14, 2024
Merged
Changetxpool_beusPendingTransactions:numResults from a required parameter to an optional parameter #6708fab-10 merged 16 commits intobesu-eth:mainfrom
txpool_beusPendingTransactions:numResults from a required parameter to an optional parameter #6708fab-10 merged 16 commits intobesu-eth:mainfrom
Conversation
MASDXI
changed the title
txpool_beusPendingTransactions: limit from a required parameter to an optional parameter
MASDXI
changed the title
txpool_beusPendingTransactions: limit from a required parameter to an optional parameter txpool_beusPendingTransactions:limit from a required parameter to an optional parameter
Signed-off-by: MASDXI <sirawitt42@gmail.com>
Signed-off-by: MASDXI <sirawitt42@gmail.com>
Signed-off-by: MASDXI <sirawitt42@gmail.com>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: MASDXI <sirawitt42@gmail.com>
…-eth#6711) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: MASDXI <sirawitt42@gmail.com>
…esu-eth#6702) * relax JsonCallParameter constructor to allow for both input and data being set if equal Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> * fix: format Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> * add changelog entry Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> --------- Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: MASDXI <sirawitt42@gmail.com>
* added more spec tests Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * fixed typo Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * fixed error message Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: MASDXI <sirawitt42@gmail.com>
…6676) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: MASDXI <sirawitt42@gmail.com>
…e it (besu-eth#6675) * Don't start a BFT mining coordinator when it is created, just enable it Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Update change log Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Matt Whitehead <matthew.whitehead@kaleido.io> Signed-off-by: MASDXI <sirawitt42@gmail.com>
* make artifacts more snapshot friendly * break out new workflows for snapshots, and a develop releease * removes checking for approval, runs on pr update * adds concurrency so updated refs cancel prior runs if still running * explicitly disable caching on gradle setup tasks --------- Signed-off-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: MASDXI <sirawitt42@gmail.com>
Signed-off-by: MASDXI <sirawitt42@gmail.com>
fab-10
requested changes
Mar 13, 2024
Contributor
fab-10
left a comment
fab-10
left a comment
There was a problem hiding this comment.
The change makes sense, a couple of suggestions and please add unit tests to validate the change.
Note that since the txpool could contain many MB of data, and if requesting all txs, it is still possible that are limits elsewhere (HTTP, proxies, etc...) that could prevent to get the full response
...rg/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/TxPoolBesuPendingTransactions.java
Show resolved
Hide resolved
MASDXI
changed the title
txpool_beusPendingTransactions:limit from a required parameter to an optional parameter txpool_beusPendingTransactions:numResults from a required parameter to an optional parameter
reuse 'pendingTransactions' to avoid fetching txs in pool twice Signed-off-by: MASDXI <sirawitt42@gmail.com>
Signed-off-by: MASDXI <sirawitt42@gmail.com>
fab-10
approved these changes
Mar 14, 2024
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
…arameter to an optional parameter (besu-eth#6708) Signed-off-by: MASDXI <sirawitt42@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
…arameter to an optional parameter (besu-eth#6708) Signed-off-by: MASDXI <sirawitt42@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
…arameter to an optional parameter (besu-eth#6708) Signed-off-by: MASDXI <sirawitt42@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Most advanced CI tests are deferred until PR approval, but you could:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTestsPR description
Enhancement
TX_POOLAPItxpool_besuPendingTransactionsby changing 'numResults' from a required parameter to an optional parameter. if the parameterlimitdoes not exist will use pending transactions size as a limit.Fixed Issue(s)
fixes #6707