Extend error handling of plugin RPC methods#6759
Merged
fab-10 merged 2 commits intobesu-eth:mainfrom Mar 20, 2024
Merged
Conversation
fab-10
changed the title
fab-10
force-pushed
the
improve-plugin-rpc-error-handling
branch
from
67ceb03 to
d23b36c
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
improve-plugin-rpc-error-handling
branch
from
d23b36c to
99d35ee
Compare
jflo
approved these changes
Mar 20, 2024
Contributor
jflo
left a comment
jflo
left a comment
There was a problem hiding this comment.
Big improvement, great test coverage.
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: amsmota <antonio.mota@citi.com>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
Extend
PluginRpcEndpointExceptionso that it requires aRpcMethodErrorthat will be used to format standard error responses.Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Most advanced CI tests are deferred until PR approval, but you could:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests