Conversation
85c9ee2 to
8d8c6c6
Compare
| pluginManagement { | ||
| repositories { | ||
| gradlePluginPortal() | ||
| maven { |
There was a problem hiding this comment.
Is this needed? There are no plugins from the tech.pegasys namespace.
There was a problem hiding this comment.
it is needed because new web3j plugin has tech.pegasys:jc-kzg-4844 as dependency
There was a problem hiding this comment.
That's not good. Web3j cannot be loaded entirely from maven central? Consensys should invest time in getting these published to Maven Central.
There was a problem hiding this comment.
I know someone is already working on that, so this will not be required in a future version, in the meantime what you prefer, using version 4.10.0 of the plugin or temporarily keeping the extra repo here?
There was a problem hiding this comment.
We do have the repository in our general listings. I was hoping we could keep the plugins section minimal. So this is acceptable since a long term solution is progressing.
6310814 to
a370514
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
a370514 to
5c0f303
Compare
# Conflicts: # CHANGELOG.md
* Update Web3j dependencies Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Force old version of the solidity compiler to pass AT Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> --------- Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: amsmota <antonio.mota@citi.com>
* Update Web3j dependencies Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Force old version of the solidity compiler to pass AT Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> --------- Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: amsmota <antonio.mota@citi.com>
* Update Web3j dependencies Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Force old version of the solidity compiler to pass AT Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> --------- Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
* Update Web3j dependencies Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Force old version of the solidity compiler to pass AT Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> --------- Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
PR description
Compilation is failing due some web3j artifacts not available anymore, so just updating them to latest verison
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests