Merged
Conversation
macfarla
reviewed
Mar 29, 2024
| try { | ||
| final boolean isEmptyRange = | ||
| (response.slots().isEmpty() || response.slots().get(0).isEmpty()) | ||
| && !response.proofs().isEmpty(); |
Contributor
There was a problem hiding this comment.
should this be ((A || B) && !C)
or
(A || (B & !C))
does it make sense for the response.slots to be empty if response.proofs is not empty
Contributor
Author
There was a problem hiding this comment.
this is correct as written. If there were no slots in the range besu will return no slots and a proof of exclusion 👍 .
edit: I realize on second read you are asking about order of evaluation.
Contributor
Author
There was a problem hiding this comment.
|| takes precedent over &&, so this should be ((A || B) && !C). 🙏
(which is how it is written, but it is hard to tell because it is split across lines)
Contributor
There was a problem hiding this comment.
added a suggested rewrite for the comment
macfarla
approved these changes
Mar 29, 2024
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/snapsync/RequestDataStep.java
Outdated
Show resolved
Hide resolved
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/snapsync/RequestDataStep.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
…still can accept remote connections Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
snap-client-fixes
branch
from
8cb313c to
6339b7f
Compare
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
* manage empty range for storage * round rather than floor on max remote connections so that maxpeers=1 still can accept remote connections --------- Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Karim Taam <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
* manage empty range for storage * round rather than floor on max remote connections so that maxpeers=1 still can accept remote connections --------- Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Karim Taam <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
* manage empty range for storage * round rather than floor on max remote connections so that maxpeers=1 still can accept remote connections --------- Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Karim Taam <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jun 7, 2024
* manage empty range for storage * round rather than floor on max remote connections so that maxpeers=1 still can accept remote connections --------- Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Karim Taam <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
snap client fixes discovered during besu snap-client -> besu snap-server testing.
RIP coder buddy