Add new PoA network option to use bootnodes during any peer table refresh, not just the first one#7314
Merged
matthew1001 merged 6 commits intobesu-eth:mainfrom Jul 23, 2024
Merged
Conversation
… not just the first one Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
matthew1001
changed the title
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
This was referenced Jul 22, 2024
pinges
approved these changes
Jul 23, 2024
Contributor
pinges
left a comment
pinges
left a comment
There was a problem hiding this comment.
I have added one suggestion. Otherwise LGTM.
.../main/java/org/hyperledger/besu/ethereum/p2p/discovery/internal/PeerDiscoveryController.java
Outdated
Show resolved
Hide resolved
…iscovery/internal/PeerDiscoveryController.java Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: Matt Whitehead <matthew1001@hotmail.com>
gconnect
pushed a commit
to gconnect/besu
that referenced
this pull request
Aug 26, 2024
…resh, not just the first one (besu-eth#7314) * Add new config option to use bootnodes during any peer table refresh, not just the first one Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Update everything-config list Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Revert debug setting Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Update ethereum/p2p/src/main/java/org/hyperledger/besu/ethereum/p2p/discovery/internal/PeerDiscoveryController.java Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: Matt Whitehead <matthew1001@hotmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Matt Whitehead <matthew1001@hotmail.com> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: gconnect <agatevureglory@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
This PR adds the option (in PoA networks only) to query the bootnodes whenever the peer table is being refreshed.
The behaviour today is that the bootnodes are queried on first startup, but if no peers are found on that occasion Besu will not use the bootnode again until it is restarted.
The new option is
onby default. Setting--poa-discovery-retry-bootnodes=falsedisables it.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests