Skip to content

Do not maintain connections to bootnodes#7358

Merged
macfarla merged 4 commits intobesu-eth:mainfrom
matthew1001:bootnode-revert
Jul 26, 2024
Merged

Do not maintain connections to bootnodes#7358
macfarla merged 4 commits intobesu-eth:mainfrom
matthew1001:bootnode-revert

Conversation

@matthew1001
Copy link
Copy Markdown
Contributor

@matthew1001 matthew1001 commented Jul 22, 2024

PR description

Reverts PR #7257 (see discussion in discord here https://discord.com/channels/905194001349627914/1261258835767726090/1264853661654454305)

The preferred behaviour is #7314 and is on by default for PoA chains.

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Copy link
Copy Markdown
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla merged commit a1efd21 into besu-eth:main Jul 26, 2024
gconnect pushed a commit to gconnect/besu that referenced this pull request Aug 26, 2024
* Do not maintain connections to bootnodes

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>

* Update changelog entry

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>

---------

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>
Signed-off-by: gconnect <agatevureglory@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants