block header cache not initialized before used#7601
Merged
macfarla merged 3 commits intobesu-eth:mainfrom Sep 10, 2024
Merged
Conversation
Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
44ec697 to
2a9d85b
Compare
Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
auto-merge was automatically disabled
September 10, 2024 23:13
Head branch was pushed to by a user without write access
jframe
approved these changes
Sep 10, 2024
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
After this commit the block headers cache is being used before it's initialized which creates an NPE while setting up the metrics:
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests