Fix registering new metric categories from plugins#7825
Merged
fab-10 merged 1 commit intobesu-eth:mainfrom Oct 30, 2024
Merged
Conversation
fab-10
force-pushed
the
fix-metric-category-registration-from-plugin
branch
from
e3f468a to
abe8635
Compare
fab-10
force-pushed
the
fix-metric-category-registration-from-plugin
branch
2 times, most recently
from
9f04a46 to
26fbea9
Compare
Contributor
|
fixes #7818 |
jflo
approved these changes
Oct 30, 2024
Contributor
jflo
left a comment
jflo
left a comment
There was a problem hiding this comment.
great move getting rid of the need for converters
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
fix-metric-category-registration-from-plugin
branch
from
26fbea9 to
2b42d31
Compare
8 tasks
JanetMo
pushed a commit
to JanetMo/besu
that referenced
this pull request
Nov 17, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
This PR fixes an issue with new metric categories registered by plugins and enabled via
metrics-categoriesoption, since when the plugin registers them it is already too late in the startup process, and Besu fails reporting an unknown metric category option.To fix this, the validation of the metric categories have been postponed to the moment we build the metric configuration from the metrics options, because at that point all is set.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests