Add TLS/mTLS options for websockets #7854
Merged
fab-10 merged 8 commits intobesu-eth:mainfrom Nov 8, 2024
Merged
Conversation
added 3 commits
October 17, 2024 14:45
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
fab-10
reviewed
Nov 5, 2024
Contributor
fab-10
left a comment
fab-10
left a comment
There was a problem hiding this comment.
Nice, thanks for the contribution, please add a CHANGELOG entry.
fab-10
added
the
doc-change-required
Contributor
|
This test is failing |
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Contributor
Author
|
@fab-10 Thanks for looking into it. Fixed and verified the failing test. Also added a PEM testcase and option dependencies |
fab-10
reviewed
Nov 7, 2024
Contributor
fab-10
left a comment
fab-10
left a comment
There was a problem hiding this comment.
LGTM, just adjust the CHANGELOG entry
CHANGELOG.md
Outdated
|
|
||
| ### Breaking Changes | ||
| - Besu will now fail to start if any plugins encounter errors during initialization. To allow Besu to continue running despite plugin errors, use the `--plugin-continue-on-error` option. [#7662](https://github.com/hyperledger/besu/pull/7662) | ||
| - Support for enabling and configuring TLS/mTLS in WebSocket service. [#7854](https://github.com/hyperledger/besu/pull/7854) |
Contributor
There was a problem hiding this comment.
move it to the [Unreleased] section under Additions and Improvements
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
fab-10
reviewed
Nov 7, 2024
Contributor
fab-10
left a comment
fab-10
left a comment
There was a problem hiding this comment.
CHANGELOG not correct yet
CHANGELOG.md
Outdated
| - Add support for `chainId` in `CallParameters` [#7720](https://github.com/hyperledger/besu/pull/7720) | ||
| - Add `--ephemery` network support for Ephemery Testnet [#7563](https://github.com/hyperledger/besu/pull/7563) thanks to [@gconnect](https://github.com/gconnect) | ||
| - Add configuration of Consolidation Request Contract Address via genesis configuration [#7647](https://github.com/hyperledger/besu/pull/7647) | ||
| - Support for enabling and configuring TLS/mTLS in WebSocket service. [#7854](https://github.com/hyperledger/besu/pull/7854) |
Contributor
There was a problem hiding this comment.
needs to be moved under ## [Unreleased] at the top, not under 24.10.0 that has been already released
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Contributor
Author
|
Ah, sorry for the oversight, corrected it . |
Contributor
|
Perfect, could you merge this branch with the main branch, since GH reports there are 2 conflicts and the PR cannot be merged |
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Contributor
Author
Done |
fab-10
approved these changes
Nov 8, 2024
JanetMo
pushed a commit
to JanetMo/besu
that referenced
this pull request
Nov 17, 2024
* Fix incorrect duration for THREE_MINUTES from 1 minute to 3 minutes Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Add options to enable TLS/mTLS for websocket connections Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Revert an irrelevant change Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Update tests, options and option dependencies Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Fix CHANGELOG entry Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Fix CHANGELOG entry Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> --------- Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> Co-authored-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Nov 22, 2024
* Fix incorrect duration for THREE_MINUTES from 1 minute to 3 minutes Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Add options to enable TLS/mTLS for websocket connections Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Revert an irrelevant change Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Update tests, options and option dependencies Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Fix CHANGELOG entry Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> * Fix CHANGELOG entry Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> --------- Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> Co-authored-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
bgravenorst
removed
the
doc-change-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1165