Add TLS/mTLS options and configure the GraphQL HTTP service#7910
Merged
macfarla merged 18 commits intobesu-eth:mainfrom Feb 12, 2025
Merged
Add TLS/mTLS options and configure the GraphQL HTTP service#7910macfarla merged 18 commits intobesu-eth:mainfrom
macfarla merged 18 commits intobesu-eth:mainfrom
Conversation
added 2 commits
November 22, 2024 12:50
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
macfarla
previously requested changes
Dec 3, 2024
Contributor
macfarla
left a comment
macfarla
left a comment
There was a problem hiding this comment.
overall looks good, just would like to not be adding (test) code that references ommers
...eum/api/src/test/java/org/hyperledger/besu/ethereum/api/graphql/GraphQLHttpsServiceTest.java
Outdated
Show resolved
Hide resolved
...eum/api/src/test/java/org/hyperledger/besu/ethereum/api/graphql/GraphQLHttpsServiceTest.java
Outdated
Show resolved
Hide resolved
...eum/api/src/test/java/org/hyperledger/besu/ethereum/api/graphql/GraphQLHttpsServiceTest.java
Outdated
Show resolved
Hide resolved
bgravenorst
added
the
doc-change-required
|
This pr is stale because it has been open for 30 days with no activity. |
Contributor
|
@pullurib are you still working on this PR? |
Contributor
Author
|
Yes, @Gabriel-Trintinalia , I'll make review changes soon. |
…raphql/GraphQLHttpsServiceTest.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <59369753+pullurib@users.noreply.github.com>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Contributor
Author
|
@macfarla, made the suggested changes . It's ready for review |
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
macfarla
reviewed
Feb 6, 2025
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <59369753+pullurib@users.noreply.github.com>
macfarla
approved these changes
Feb 7, 2025
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
alexandratran
removed
the
doc-change-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
The changes include the addition of command-line options to enable and configure TLS and mTLS for the GraphQL HTTP service.
Changes
New Command-Line Options:
--graphql-tls-enabled: Enable TLS for the GraphQL HTTP service.--graphql-tls-keystore-file: Path to the TLS keystore file.--graphql-tls-keystore-password-file: Path to the file containing the password for the TLS keystore.--graphql-mtls-enabled: Enable mTLS for the GraphQL HTTP service.--graphql-tls-truststore-file: Path to the TLS truststore file.--graphql-tls-truststore-password-file: Path to the file containing the password for the TLS truststore.Validation of Option Dependencies:
Testing
Documentation
CHANGELOG.mdto reflect the addition of new TLS options.Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests