Improve Conflict Detection in Parallelization by Considering Slots to Reduce False Positives#7923
Merged
matkt merged 15 commits intobesu-eth:mainfrom Feb 17, 2025
Merged
Conversation
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Contributor
Contributor
Author
|
we need to do stability tests before merging |
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
...ava/org/hyperledger/besu/ethereum/mainnet/parallelization/MainnetParallelBlockProcessor.java
Show resolved
Hide resolved
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
ahamlat
approved these changes
Dec 3, 2024
ahamlat
requested changes
Dec 3, 2024
...hereum/trie/diffbased/common/worldview/accumulator/DiffBasedWorldStateUpdateAccumulator.java
Outdated
Show resolved
Hide resolved
- copy storageKeyHashLookup when cloning accumulator Signed-off-by: Karim Taam <karim.t2am@gmail.com>
macfarla
reviewed
Dec 4, 2024
...java/org/hyperledger/besu/ethereum/mainnet/parallelization/TransactionCollisionDetector.java
Outdated
Show resolved
Hide resolved
...java/org/hyperledger/besu/ethereum/mainnet/parallelization/TransactionCollisionDetector.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
68a5c15 to
85bfd20
Compare
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
788f628 to
9985e73
Compare
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
ahamlat
approved these changes
Feb 17, 2025
Contributor
ahamlat
left a comment
There was a problem hiding this comment.
LGTM, comparing with the first version of the parallelization, this PR has better performances even on 4 Cores, without more overhead. Conflict detection takes even less time than the first version.
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Contributor
Author
done |
0a23a9b to
552bc52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




PR description
This update improve conflict detection during transaction parallelization by checking storage slot changes. By considering modified slots in addition to addresses, we improve the accuracy of conflict detection.
Key Changes:
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests