Remove P2P TLS (experimental) feature#7942
Merged
macfarla merged 9 commits intobesu-eth:mainfrom Nov 29, 2024
Merged
Conversation
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
fab-10
requested changes
Nov 27, 2024
Contributor
fab-10
left a comment
fab-10
left a comment
There was a problem hiding this comment.
nice cleanup! one missing thing: pki should be removed from settings.gradle too
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
fab-10
approved these changes
Nov 28, 2024
ahamlat
pushed a commit
to ahamlat/besu
that referenced
this pull request
Dec 2, 2024
Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Remove TLS for P2P, and remove remaining PKI classes (PKI module)
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests