Fix the simulation of txs with future nonce#8215
Merged
fab-10 merged 2 commits intobesu-eth:mainfrom Feb 3, 2025
Merged
Conversation
fab-10
force-pushed
the
fix-simulating-tx-with-future-nonce
branch
from
01bf7a8 to
7ae4399
Compare
fab-10
force-pushed
the
fix-simulating-tx-with-future-nonce
branch
from
7ae4399 to
73cfa08
Compare
Gabriel-Trintinalia
approved these changes
Feb 1, 2025
Contributor
|
failing some EthCall unit tests. changing to draft pending unit test fixes |
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
fix-simulating-tx-with-future-nonce
branch
from
73cfa08 to
3154aa2
Compare
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
With #8139 call parameters support the nonce, but the simulation of a tx with a future nonce fails because we were strictly checking the next nonce for the sender, why we should allow for the simulation of any nonce greater than the current one.
Fixed Issue(s)
related to #8139
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests