Add a tx selector to skip txs from the same sender after the first not selected#8216
Merged
fab-10 merged 1 commit intobesu-eth:mainfrom Feb 3, 2025
Merged
Conversation
garyschulte
approved these changes
Jan 31, 2025
Contributor
garyschulte
left a comment
garyschulte
left a comment
There was a problem hiding this comment.
LGTM, but needs an updated plugin-api hash to pass CI
…t selected Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
skip-sender-tx-selector
branch
from
616a8c4 to
820cc51
Compare
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
…t selected (besu-eth#8216) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
During block creation, if a sender has more that one pending txs and one of them if not selected for any reason, then it is worthless to keep evaluation other pending txs from the same sender, since they will also be not selected due to the nonce gap.
Before this PR, this check was only done in the layered txpool, but it is better to move it as a standard tx selector, so it applies also to the sequenced txpool.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests