Skip to content

change invalid block param error message#8328

Merged
macfarla merged 6 commits intobesu-eth:mainfrom
macfarla:invalid-block-param-msg
Feb 21, 2025
Merged

change invalid block param error message#8328
macfarla merged 6 commits intobesu-eth:mainfrom
macfarla:invalid-block-param-msg

Conversation

@macfarla
Copy link
Copy Markdown
Contributor

PR description

The "invalid RLP" message is misleading - this changes it to something more representative. It's generally that we're passing a block number or hash that is just not found.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@macfarla macfarla enabled auto-merge (squash) February 21, 2025 00:00
@macfarla macfarla merged commit ecda0cd into besu-eth:main Feb 21, 2025
43 checks passed
@macfarla macfarla deleted the invalid-block-param-msg branch March 5, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants