Skip to content

Sepolia: Fix for deposit contract log decoding#8383

Merged
fab-10 merged 2 commits intobesu-eth:mainfrom
fab-10:fix-sepolia-deposit-contract
Mar 5, 2025
Merged

Sepolia: Fix for deposit contract log decoding#8383
fab-10 merged 2 commits intobesu-eth:mainfrom
fab-10:fix-sepolia-deposit-contract

Conversation

@fab-10
Copy link
Copy Markdown
Contributor

@fab-10 fab-10 commented Mar 5, 2025

PR description

Implement the filtering by deposit event sig hash, as described here
https://github.com/ethereum/EIPs/pull/9453/files

Fixed Issue(s)

fixes #8381

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Copy link
Copy Markdown
Contributor

@ahamlat ahamlat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
@daniellehrner daniellehrner marked this pull request as ready for review March 5, 2025 14:08
@fab-10 fab-10 enabled auto-merge (squash) March 5, 2025 14:12
@fab-10 fab-10 merged commit 751c9f9 into besu-eth:main Mar 5, 2025
43 checks passed
@fab-10 fab-10 deleted the fix-sepolia-deposit-contract branch March 5, 2025 14:33
fab-10 added a commit to fab-10/besu that referenced this pull request Mar 5, 2025
* Sepolia: Fix for deposit contract log decoding

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* add tests

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

---------

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Co-authored-by: Daniel Lehrner <daniel.lehrner@consensys.net>
marcosio pushed a commit to IoBuilders/besu that referenced this pull request Mar 12, 2025
* Sepolia: Fix for deposit contract log decoding

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* add tests

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

---------

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Co-authored-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Marcos Serradilla Diez <marcos@io.builders>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sepolia: Fix for deposit contract log decoding

3 participants